This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
chore: fix wrong essential param to optional #197
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenji-miyake
reviewed
Feb 8, 2022
kenji-miyake
changed the title
Fix wrong param line
chore: fix wrong essential param to optional
Feb 8, 2022
kenji-miyake
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, I edited the PR title for conventional commits.
Please re-edit it if you prefer another one. 🙇
takayuki5168
pushed a commit
that referenced
this pull request
May 26, 2022
* Fix incorrect remap (#183) * Fix incorrect remap Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use set_remap Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) (#196) * add septentrio_gnss_driver launcher and switch(septentrio <-> ublox) * rm arg(gnss_receiver) escalation and modify septentrio_gnss_driver_node option * change gnss_receiver default septentrio to ublox * remap all septentrio_gnss_driver topic names * replace septentrio gnss driver launch type 'node' to 'include' * Use set_parameter for use_sim_time (#198) * Use set_parameter for use_sim_time Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add default parameter for scenario simulator Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * change system_monitor.launch.xml to launch.py (#203) * Add control composed launch (#201) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * add param for psim v2 (#197) * add param for psim v2 Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp> * Update to pass var 'scenario_simulation' to dummy_perception_publisher * Update dummy_perception_publisher's arg-name Co-authored-by: yamacir-kit <httperror@404-notfound.jp> * Feature/porting v0.9.1 master (#202) * add simulation arg (#174) * add simulation arg * add comment * change arg name * add parameter use_empty_dynamic_object_publisher into perception.launch (#176) Signed-off-by: Azumi Suzuki <azumi.suzuki@tier4.jp> Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> * Fix mistakes in control.launch.py (#209) * Fix typo in control.launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add remote_cmd_converter_component Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Feature/add external cmd selector (#206) * Add remote_cmd_selector to control.launch (#172) * Add remote_cmd_selector to control.launch Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Rename remote_cmd_selector to external_cmd_selector Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change default external cmd source (#173) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * modify to use control.launch.xml * add external_cmd_selector to control.launch.py * Fix remapping in control.launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix remapping in control.launch.py again Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> * Add vehicle info launch for setting vehicle info param (#199) * Add vehicle info launch for setting vehicle info param Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add comment for global parameters section Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Fix year and apply format Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove ready vehicle info param Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove vehicle info param server from logging simulator (#211) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Add container launch for planning (#205) * Add container launch for planning Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix porting miss * fix lane_driving.launch.xml * Add missing parameters Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: taichiH <azumade.30@gmail.com> * Add map.launch.py (#212) * Add map.launch.py Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Update map.launch.xml Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Rename parameter for lanelet2 map path Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * Rename AstarNavi to FreespacePlannerNode (#213) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add spell check action (#214) * Unify YAML file extension of GitHub action to yml (#216) * Fix PR template (#218) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix PR template link (#219) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix minor typos in PULL_REQUEST_TEMPLATE.md (#222) * Fix depends in localization_launch to exec_depend (#223) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add build CI (#224) * Add build CI Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix build_depend.repos Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add private repository settings Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Remove self repo Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Install pip Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Use packages-select and packages-up-to Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Change job name Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Add build_and_test.yml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Install kvaser library Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Build only internal packages in CI (#227) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix typos in launch files (#231) * Fix typos in launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp> * Format launch files (#228) * Format launch files Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Format launch.py Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Fix lint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * Exclude dummy_perception_publisher.launch.xml if is scenario_simulation (#230) * Fix unresolved conflicts Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: hiro-ya-iv <30652835+hiro-ya-iv@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: Taichi Higashide <taichi.higashide@tier4.jp> Co-authored-by: Kosuke Murakami <kosuke.murakami@tier4.jp> Co-authored-by: yamacir-kit <httperror@404-notfound.jp> Co-authored-by: Keisuke Shima <keisuke.shima@tier4.jp> Co-authored-by: Yusuke FUJII <yusuke.fujii@tier4.jp> Co-authored-by: s-azumi <38061530+s-azumi@users.noreply.github.com> Co-authored-by: taichiH <azumade.30@gmail.com> Co-authored-by: Kazuki Miyahara <kmiya@outlook.com> Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>
takayuki5168
added a commit
that referenced
this pull request
May 26, 2022
* chore: fix CI settings (#182) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: sync files (#180) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync files (#184) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: add paricle param (#181) Signed-off-by: YamatoAndo <yamato.ando@gmail.com> * chore: sync files (#185) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * Update sync-files.yaml Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: sync files (#186) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync system config (#187) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * chore: sync files (#189) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: wep21 <wep21@users.noreply.github.com> * chore: replace system config in system launch (#188) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * feat: adds additional configuration flags for behavior_path_planner (#171) * feat: adds additional configuration flags for behavior_path_planner The additional configuration is used to allows avoidance over lane with same and different direction, as well as allows safety margin between linestring and ego. This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496 port. Related PR: autowarefoundation/autoware.universe#285 autowarefoundation/autoware.universe#287 Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Change lateral_collision_margion to 1.0 to reflect changes. The decision to change the parameter value to 1.0 is made after performing drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting between planning control team on 3rd of February 2022. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix: slightly increase the safety buffer. This increases the shift length to 1.7 + 0.5 * vehicle width. The decision to increase is based on the discussion between planning team and also the advice from the FI team. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat(behavior_velocity): add path marker visualization (#190) Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: sync files (#193) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync files (#194) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * chore: update workflow files name Signed-off-by: h-ohta <hiroki.ota@tier4.jp> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> Co-authored-by: h-ohta <hiroki.ota@tier4.jp> * chore: sync files (#195) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> * feat: lateral controller param (#191) * feat: define lat_controller_param_path * feat: change for trajectory_follower params * add args for lat_controller_param_path * chore: fix wrong essential param to optional (#197) * fix wrong param line * move pointcloud_container_name param to optional * fix: typo extra `>` (#199) * Chore arrange perception rviz topics (#196) * feat(autoware_launch): add occupancy grid vizualization Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat(autoware_launch): add object recognition namespace to rviz Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: delete unused in control_launch (#200) * fix: delete unused in control.launch.py * fix: delete velocity_controller.param.yaml * feat: add system_monitor parameters in sync-files (#201) * chore: update settings of sync-files (#204) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat(control_launch): remove unnecessary params (#206) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * chore: sync files (#208) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat(atutoware.rviz): disable selectable for pointcloud visualization (#207) Signed-off-by: YamatoAndo <yamato.ando@gmail.com> * chore: sync files (#212) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat(behavior path planner): update params of behavior path for dynamic drivable area (#209) * feat: load global param (#216) * feat: load global param Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * chore: add comment about rosdistro migration Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * fix: add feature_remover after apollo segmentation (#217) Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> * chore: sync files (#222) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * Update sync-param-files.yaml Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore(perception_launch): update laserscan angle increment to pandar 64 level resolution (#220) Signed-off-by: taikitanaka <ttatcoder@outlook.jp> * feat: add enable option for image decompressor (#224) * feat: add enable option for image decompressor Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * ci: fix flake8 Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * feat(behavior_velocity): add merge from private marker (#223) * feat(behavior_velocity): add merge from private marker Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat(behavior_velocity): add factor text Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: expose traffic light model path arg (#225) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * feat(autoware_launch, simulator_launch): move perception modules to simulator.launch.xml (#227) * feat(autoware_launch, simulator_launch): move perception modules to simulator.launch.xml Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * remove unnecessary comment Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * feat(ndt_scan_matcher): add the tolerance of initial pose (#211) * feat(ndt_scan_matcher): add the tolerance of initial pose Signed-off-by: YamatoAndo <yamato.ando@gmail.com> * change param name Signed-off-by: YamatoAndo <yamato.ando@gmail.com> * ci(pre-commit): autofix Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: sync files (#229) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync files (#230) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * remove tier4/proposal Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * change cron schedules Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * sync sync-files.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat: add launch description for cpu usage adaptor (#210) Signed-off-by: TakumiKozaka-T4 <takumi.kozaka@tier4.jp> * fix: delete aip dependents (#235) * fix: delete aip dependents * Update package.xml Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: disable awapi_vehicle_get_door_topic_state_monitor (#271) Signed-off-by: Yuma Nihei <yuma.nihei@tier4.jp> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Yamato Ando <yamato.ando@gmail.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: wep21 <wep21@users.noreply.github.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> Co-authored-by: h-ohta <hiroki.ota@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: TakumiKozaka-T4 <70260442+TakumiKozaka-T4@users.noreply.github.com> Co-authored-by: Yuma Nihei <yuma.nihei@tier4.jp>
maxime-clem
pushed a commit
that referenced
this pull request
May 27, 2022
* update parameter (#169) * Port pure pursuit (#166) * Fix control.launch.py * Apply pre-commit * Fix control.launch.py * Change debug topic name in rviz setting * fix typo in localization util.launch.py (#168) * Feature/add covarinace param (#170) * add covariance param * add description * remove unused param (#172) * Bump streetsidesoftware/cspell-action from 1.3.4 to v1 (#174) * Bump streetsidesoftware/cspell-action from 1.3.4 to 1.5.0 Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 1.3.4 to 1.5.0. - [Release notes](https://github.com/streetsidesoftware/cspell-action/releases) - [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md) - [Commits](streetsidesoftware/cspell-action@v1.3.4...v1.5.0) --- updated-dependencies: - dependency-name: streetsidesoftware/cspell-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update spell_check_pr.yml Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix: fix hdd_monitor param (#173) * add rosbridge launch (#175) * add rosbridge launch * fix TODO document add link to pull request Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * fix double-byte character Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: sync files (#177) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * ci: update CI settings (#176) * ci(pre-commit): update .pre-commit-config.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ci: add sync-files.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: remove old workflows Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ci(sync-upstream): update sync-upstream.yaml Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * ci(pre-commit): autofix * style: fix for yamllint Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * chore: minor update CI settings (#179) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * [pre-commit.ci] pre-commit autoupdate (#178) updates: - [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0) - [github.com/igorshubovych/markdownlint-cli: v0.29.0 → v0.30.0](igorshubovych/markdownlint-cli@v0.29.0...v0.30.0) - [github.com/pre-commit/mirrors-prettier: v2.4.1 → v2.5.1](pre-commit/mirrors-prettier@v2.4.1...v2.5.1) - [github.com/pycqa/isort: 5.9.3 → 5.10.1](PyCQA/isort@5.9.3...5.10.1) - [github.com/psf/black: 21.9b0 → 22.1.0](psf/black@21.9b0...22.1.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: fix CI settings (#182) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * chore: sync files (#180) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync files (#184) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat: add paricle param (#181) Signed-off-by: YamatoAndo <yamato.ando@gmail.com> * chore: sync files (#185) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * Update sync-files.yaml Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> * chore: sync files (#186) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync system config (#187) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * chore: sync files (#189) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: wep21 <wep21@users.noreply.github.com> * chore: replace system config in system launch (#188) Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> * feat: adds additional configuration flags for behavior_path_planner (#171) * feat: adds additional configuration flags for behavior_path_planner The additional configuration is used to allows avoidance over lane with same and different direction, as well as allows safety margin between linestring and ego. This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496 port. Related PR: autowarefoundation/autoware.universe#285 autowarefoundation/autoware.universe#287 Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Change lateral_collision_margion to 1.0 to reflect changes. The decision to change the parameter value to 1.0 is made after performing drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting between planning control team on 3rd of February 2022. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix: slightly increase the safety buffer. This increases the shift length to 1.7 + 0.5 * vehicle width. The decision to increase is based on the discussion between planning team and also the advice from the FI team. Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * feat(behavior_velocity): add path marker visualization (#190) Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: sync files (#193) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: sync files (#194) * chore: sync files Signed-off-by: GitHub <noreply@github.com> * chore: update workflow files name Signed-off-by: h-ohta <hiroki.ota@tier4.jp> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> Co-authored-by: h-ohta <hiroki.ota@tier4.jp> * chore: sync files (#195) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> * feat: lateral controller param (#191) * feat: define lat_controller_param_path * feat: change for trajectory_follower params * add args for lat_controller_param_path * chore: fix wrong essential param to optional (#197) * fix wrong param line * move pointcloud_container_name param to optional * fix: typo extra `>` (#199) * Chore arrange perception rviz topics (#196) * feat(autoware_launch): add occupancy grid vizualization Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * feat(autoware_launch): add object recognition namespace to rviz Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: delete unused in control_launch (#200) * fix: delete unused in control.launch.py * fix: delete velocity_controller.param.yaml * feat: add system_monitor parameters in sync-files (#201) * chore: sync files (#202) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> * chore: sync files (#203) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * chore: update settings of sync-files (#204) Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp> * feat(control_launch): remove unnecessary params (#206) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * chore: sync files (#208) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * feat(atutoware.rviz): disable selectable for pointcloud visualization (#207) Signed-off-by: YamatoAndo <yamato.ando@gmail.com> * chore: sync files (#212) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> * delete vehicle parameters in longitudinal_controller.param.yaml * apply pre-commit * remove unused file * update sync-param-files.yaml * disable local_external_control in system_error_montitor_psim Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp> Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> Co-authored-by: YamatoAndo <yamato.ando@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com> Co-authored-by: yabuta <makoto.yabuta@tier4.jp> Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com> Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com> Co-authored-by: wep21 <wep21@users.noreply.github.com> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com> Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com> Co-authored-by: h-ohta <h-ohta@users.noreply.github.com> Co-authored-by: h-ohta <hiroki.ota@tier4.jp> Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
tier4-autoware-public-bot bot
pushed a commit
that referenced
this pull request
Feb 10, 2023
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This was referenced Feb 15, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
Description
Fixed a parameter that was written in the wrong line.
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks