Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick/pr6608+6585 #1198

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Cherry pick/pr6608+6585 #1198

merged 2 commits into from
Mar 19, 2024

Conversation

soblin
Copy link

@soblin soblin commented Mar 19, 2024

Description

の盛り込みです.スプレッドシートに書きましたが効くシーンはそんなにないと思います.

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

soblin added 2 commits March 19, 2024 22:41
… from green to yellow/red (autowarefoundation#6608)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…riangle (autowarefoundation#6585)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Copy link
Collaborator

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk enabled auto-merge March 19, 2024 14:07
@shmpwk shmpwk disabled auto-merge March 19, 2024 14:08
@shmpwk shmpwk merged commit 37dfa79 into beta/v0.20.1.5 Mar 19, 2024
12 of 13 checks passed
@shmpwk shmpwk deleted the cherry-pick/pr6608+6585 branch March 19, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants