-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(intersection_occlusion): quickly delete occlusion wall on change from green to yellow/red #6608
Conversation
5a8d97e
to
6b3f4d4
Compare
… from green to yellow/red Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
6b3f4d4
to
cd25015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6608 +/- ##
=======================================
Coverage 14.79% 14.80%
=======================================
Files 1920 1920
Lines 132349 132271 -78
Branches 39339 39316 -23
=======================================
Hits 19580 19580
+ Misses 90934 90857 -77
+ Partials 21835 21834 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… from green to yellow/red (autowarefoundation#6608) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
… from green to yellow/red (autowarefoundation#6608) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
… from green to yellow/red (autowarefoundation#6608) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
… from green to yellow/red (autowarefoundation#6608) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
if the priority level changed from NOT_PRIORITIZED to PRIORITIZED, the intersection_occlusion wall is quickly removed for smooth start.
before this PR
there is a short elapsed time gap until intersection_occlusion is cleared ( about 1~2 second).
PR6608before.mp4
after this PR
there is very few delay.
PR6608-2024-03-13_17.24.02.mp4
Related links
https://tier4.atlassian.net/browse/RT1-5444
Tests performed
https://evaluation.tier4.jp/evaluation/reports/9fa78d8a-3af7-5dc1-ab69-19d8d9a7a7d5?project_id=prd_jt
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.