Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection_occlusion): quickly delete occlusion wall on change from green to yellow/red #6608

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 13, 2024

Description

if the priority level changed from NOT_PRIORITIZED to PRIORITIZED, the intersection_occlusion wall is quickly removed for smooth start.

before this PR

there is a short elapsed time gap until intersection_occlusion is cleared ( about 1~2 second).

PR6608before.mp4

after this PR

there is very few delay.

PR6608-2024-03-13_17.24.02.mp4

Related links

https://tier4.atlassian.net/browse/RT1-5444

Tests performed

https://evaluation.tier4.jp/evaluation/reports/9fa78d8a-3af7-5dc1-ab69-19d8d9a7a7d5?project_id=prd_jt

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 13, 2024
@soblin soblin force-pushed the feat/intersection_occlusion/swift-transition-at-yellow-red-light branch from 5a8d97e to 6b3f4d4 Compare March 13, 2024 08:34
… from green to yellow/red

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/intersection_occlusion/swift-transition-at-yellow-red-light branch from 6b3f4d4 to cd25015 Compare March 13, 2024 08:45
@soblin soblin marked this pull request as ready for review March 13, 2024 09:41
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 13, 2024
@soblin soblin enabled auto-merge (squash) March 13, 2024 09:41
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 14.80%. Comparing base (680953d) to head (cd25015).
Report is 5 commits behind head on main.

Files Patch % Lines
...ion_module/src/scene_intersection_prepare_data.cpp 0.00% 5 Missing ⚠️
...ection_module/src/scene_intersection_occlusion.cpp 0.00% 4 Missing ⚠️
...ity_intersection_module/src/scene_intersection.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6608   +/-   ##
=======================================
  Coverage   14.79%   14.80%           
=======================================
  Files        1920     1920           
  Lines      132349   132271   -78     
  Branches    39339    39316   -23     
=======================================
  Hits        19580    19580           
+ Misses      90934    90857   -77     
+ Partials    21835    21834    -1     
Flag Coverage Δ *Carryforward flag
differential 4.46% <0.00%> (?)
total 14.80% <ø> (+0.01%) ⬆️ Carriedforward from 680953d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 3ba1ecd into autowarefoundation:main Mar 13, 2024
37 of 39 checks passed
@soblin soblin deleted the feat/intersection_occlusion/swift-transition-at-yellow-red-light branch March 13, 2024 10:59
yhisaki pushed a commit to yhisaki/autoware.universe that referenced this pull request Mar 15, 2024
… from green to yellow/red (autowarefoundation#6608)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request Mar 19, 2024
… from green to yellow/red (autowarefoundation#6608)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
… from green to yellow/red (autowarefoundation#6608)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
… from green to yellow/red (autowarefoundation#6608)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants