Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection_occlusion): quickly delete occlusion wall on change from green to yellow/red #6608

feat(intersection_occlusion): quickly delete occlusion wall on change…

cd25015
Select commit
Loading
Failed to load commit list.
Merged

feat(intersection_occlusion): quickly delete occlusion wall on change from green to yellow/red #6608

feat(intersection_occlusion): quickly delete occlusion wall on change…
cd25015
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 13, 2024 in 51s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scene_intersection_prepare_data.cpp: IntersectionModule::prepareIntersectionData
  • Complex Method scene_intersection_occlusion.cpp: IntersectionModule::getOcclusionStatus

Annotations

Check warning on line 82 in planning/behavior_velocity_intersection_module/src/scene_intersection_occlusion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

IntersectionModule::getOcclusionStatus increases in cyclomatic complexity from 13 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 279 in planning/behavior_velocity_intersection_module/src/scene_intersection_prepare_data.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

IntersectionModule::prepareIntersectionData already has high cyclomatic complexity, and now it increases in Lines of Code from 97 to 101. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.