Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection_occlusion): estimate dynamic occlusion source with triangle #6585

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 11, 2024

Description

modify the dynamic occlusion estimation by triangle, not by line.
form a triangle with

  • the nearest occlusion cell
  • and the occluded cell behind that cell
  • ego position
    and check if it collides with vehicles inside intersection_area

image

Related links

Tests performed

https://evaluation.tier4.jp/evaluation/reports/1a7dd4ca-b9df-5114-98e4-a821c072baa3?project_id=prd_jt

before this PR

-2024-03-11_16.58.40.mp4

after this PR

-2024-03-11_16.56.09.mp4

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…riangle

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 11, 2024
@soblin soblin marked this pull request as ready for review March 12, 2024 02:18
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 12, 2024
@soblin soblin enabled auto-merge (squash) March 12, 2024 02:36
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 14.78%. Comparing base (aa84a5e) to head (659a4a5).
Report is 15 commits behind head on main.

Files Patch % Lines
...ection_module/src/scene_intersection_occlusion.cpp 0.00% 13 Missing ⚠️
...ehavior_velocity_intersection_module/src/debug.cpp 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6585      +/-   ##
==========================================
- Coverage   14.78%   14.78%   -0.01%     
==========================================
  Files        1917     1917              
  Lines      132253   132271      +18     
  Branches    39297    39310      +13     
==========================================
  Hits        19550    19550              
- Misses      90876    90894      +18     
  Partials    21827    21827              
Flag Coverage Δ *Carryforward flag
differential 4.46% <0.00%> (?)
total 14.78% <ø> (+<0.01%) ⬆️ Carriedforward from aa84a5e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit 70bdf7f into autowarefoundation:main Mar 12, 2024
44 of 47 checks passed
@soblin soblin deleted the fix/intersection_occlusion/dynamic-occlusion-estimation branch March 12, 2024 03:36
soblin added a commit to tier4/autoware.universe that referenced this pull request Mar 19, 2024
…riangle (autowarefoundation#6585)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…riangle (autowarefoundation#6585)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…riangle (autowarefoundation#6585)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants