Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ad_service_state_monitor): lock shread variables to prevent race condition (#1395) #103

Merged
merged 1 commit into from
Sep 5, 2022
Merged

fix(ad_service_state_monitor): lock shread variables to prevent race condition (#1395) #103

merged 1 commit into from
Sep 5, 2022

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Sep 5, 2022 •
edited
Loading

Description

autowarefoundation#1395 のbackport

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.3.9@f2c64f2). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             beta/v0.3.9    #103   +/-   ##
=============================================
  Coverage               ?   0.00%           
=============================================
  Files                  ?       7           
  Lines                  ?     558           
  Branches               ?       0           
=============================================
  Hits                   ?       0           
  Misses                 ?     558           
  Partials               ?       0
Flag Coverage Δ
differential 0.00% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@h-ohta h-ohta enabled auto-merge (squash) September 5, 2022 04:58
naokimatsunawa
naokimatsunawa previously approved these changes Sep 5, 2022
View reviewed changes
Copy link

@naokimatsunawa naokimatsunawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下2コミットの変更点と同じことを確認しました。
f5d4b6f#diff-0fa8de79b31bd8827f823df2f23805c34f9bbfb3d1b6ffeb7c1f5597cd060ef1
4d67a6e#diff-52ab9f5be05b71a42a81e4b468d9ff3393a7b5de6a7a157ff917f05148e17f6a

@h-ohta h-ohta force-pushed the backport/universe_1395 branch from f5d4b6f to bdadf49 Compare September 5, 2022 07:22
@ytakano @h-ohta
fix(ad_service_state_monitor): lock shread variables to prevent race … (
2b74866 
#1395)

* fix(ad_service_state_monitor): lock shread variables to prevent race condition

state_machine_ and state_input_ are shared by multiple callback groups (threads).
So, mutex locks have been applied because it may cause race conditions.

Signed-off-by: Yuuki Takano <yuuki.takano@tier4.jp>

* fix(ad_service_state_monitor): lock state_input_

state_input_ must be locked before accessing

Signed-off-by: Yuuki Takano <yuuki.takano@tier4.jp>

* fix(ad_service_state_monitor): minimamize the steps of the critical sections

- Unlock the locks as earlier as possible.
- rename lock variables to improve readability

Signed-off-by: Yuuki Takano <yuuki.takano@tier4.jp>

* fix(ad_service_state_monitor_node): remove uneccesary unlock

Signed-off-by: Yuuki Takano <yuuki.takano@tier4.jp>
@h-ohta h-ohta force-pushed the backport/universe_1395 branch from bdadf49 to 2b74866 Compare September 5, 2022 07:25
@h-ohta h-ohta enabled auto-merge (squash) September 5, 2022 07:25
@h-ohta h-ohta disabled auto-merge September 5, 2022 07:29
@h-ohta h-ohta enabled auto-merge (squash) September 5, 2022 07:37
naokimatsunawa
naokimatsunawa approved these changes Sep 5, 2022
View reviewed changes
Copy link

@naokimatsunawa naokimatsunawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@h-ohta h-ohta merged commit ac7b04e into beta/v0.3.9 Sep 5, 2022
@h-ohta h-ohta deleted the backport/universe_1395 branch September 5, 2022 07:41
maxime-clem pushed a commit to maxime-clem/autoware.universe that referenced this pull request Feb 7, 2024
@kenji-miyake @yukkysaito
feat: add ansible setup scripts (tier4#8)
4cec604 
* ci: add build CI

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: add files for Ansible Galaxy

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: copy ansible files from tier4's proposal

Remove cache_valid_time

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

v0.4.0

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>

copy setup

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

add ros2 ansible roles

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

ansible add ubuntu20 setup

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

ansible fix pacmod

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

temp disable cuda & tensorrt

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

ansible fix kvaser library repo

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

temporally comment out for unused modules

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

remove unused codes

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

Install osqp only once (tier4#95)

* update readme and fix osqp_vendor tag

* Remove ansible osqp role

fix: ansbile role

Closes tier4#140

add ansible for cuda 11.1 & tensorrt 7.2.1 & cudnn 8.0.5

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>

add script for install livox sdk

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

add ansible sdk task

Signed-off-by: kosuke murakami <kosuke.murakami@tier4.jp>

Use Livox vendor package (tier4#156)

* Use Livox vendor package

* Removed Livox SDK from ansible

* Use upstream Livox ROS2 driver

Install kvaser library

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Update ansible/localhost-setup-ubuntu20.04-devpc.yml

Install kvaser library from origin

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Update ansible/localhost-setup-ubuntu20.04-devpc.yml

install vcstool and do vcs import in ansible setup (tier4#170)

Update documents and fix typos

* update install instructions
* remove redundant statements
* fix typos

Separate Ansible tasks related to vcs import to new role (tier4#180)

* Separate Ansible tasks related to vcs import to new role

* Move the Ansible task to install vcstool to the ROS2 role

Add rmw-cyclonedds-cpp to ansible (tier4#67)

* Add rmw-cyclonedds-cpp to ansible

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add settings to .bashrc

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Fix setup script typos (tier4#202) (tier4#73)

Signed-off-by: Lalith Vipulananthan <63835446+LalithVipulananthan@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>

Revive pacmod role (tier4#103)

* Revert "Install kvaser library from origin"

This reverts commit 3859fffd60164febbaacc2f68b045d3b0d07f3d6.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ROS role

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

install pip before rosdep (tier4#72)

Fix: Update GPG key download task for ROS2 (tier4#125)

* Fix: Update GPG key download task for ROS2

* Fix: Update comments, source list

Add pre-commit CI (tier4#167)

* Add pre-commit CI

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add .prettierrc.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Ignore some markdownlint rules

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix typo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Move to ROS2 Galactic (tier4#107)

* Fix rosdistro in ansible

Fix rosdistro other than autoware in ansible (tier4#146)

* Use upstream grid_map

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove rosbag2

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Change position of ecu_system_setup section

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add missing_packages in galactic

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add ros2/rosbag2 galactic to repos

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Purge installed rosbag2 to build it from source

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Add TODO comment to repos

Co-authored-by: tkimura4 <tomoya.kimura@tier4.jp>
Co-authored-by: kosuke55 <kosuke.tnp@gmail.com>

Install ros-galactic-ros2cli-common-extensions in ansible (tier4#183)

* Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Install ros-galactic-ros2cli-common-extensions in ansible

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Add descriptions of rosbag2 purge

Use apt installed rosbag2 (tier4#189)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Remove vcs import in ansible (tier4#198)

* Remove vcs import in ansible

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* Update installation steps

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>

fix gdown install command (tier4#214)

Simplify ansible files (tier4#122)

* Simplify ansible files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add build-pr.yml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

add libtorch (tier4#131) (tier4#191)

* add libtorch (tier4#131)

* add libtorch

* update libtorch 1.6.0 -> 1.8.1

* libtorch for CUDA 11.1

* use the same command

* libtorch 1.8.1 -> 1.6.0

* add LibTorch for CUDA 11.1

* change install order

* Deprecate 18.04 support for libtorch

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* pre-commit fixes

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: Yusuke Muramatsu <yukke42@users.noreply.github.com>

fix libtorch install (tier4#196)

Feature/remove pacmod3 (tier4#349)

* remove pacmod3

* Remove kvaser_interface from repos

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix ansible

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Fix vcs import action

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* Run pre-commit

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: wep21 <border_goldenmarket@yahoo.co.jp>

add go dependency for pre-commit (tier4#388)

* add go dependency by snap install --classic

* move install-go from autoware/ to pre-commit/

* update playbook.yml

* use apt without snap to install golang

* chore: clean up files

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix: specify pip3 executable to prevent pipx to be used

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: add docker role

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* fix: use ansible_user_id instead of ansible_env.USER

root user doesn't have ansible_env.USER.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: fix verbose option

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: remove libtorch

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: add --no-nvidia option

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* style: rename ansible_options to ansible_args

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: update CUDA versions

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: fix scripts around sudo

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat: support arm64-sbsa in CUDA role

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci: add ARM build

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: comment out simulator repositories

autowarefoundation/autoware#21
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naokimatsunawa naokimatsunawa naokimatsunawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@h-ohta @codecov-commenter @naokimatsunawa @ytakano