Using mockRunLogs in a better way #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using mockRunLog setting/getter for stdOut
Closed
opotowsky
approved these changes
Jan 19, 2023
drewj-usnctech
added a commit
to drewj-usnctech/armi
that referenced
this pull request
Jan 23, 2023
…30/assembly-1d-parent-class * terrapower/main: Adding measure of convergence for tight coupling (terrapower#1033) Fixing ruamel.yaml deprecation warning (terrapower#1109) Fix Issues with Peak Params (terrapower#1108) Adding a helper method to validate versions in settings files (terrapower#1102) Using fuelCycle settings constants (terrapower#1107) Using mockRunLogs in a better way (terrapower#1106) Using module-level neutronics settings constants (terrapower#1104) Cleanup umc (terrapower#1099) Fixing broken doc link for mpi4py (terrapower#1105) Improving logic for getNumPins (terrapower#1098) fix `code-block` sphinx errors (terrapower#1091) Defer setting material number in MCNP material card (terrapower#1086) Efficiency improvement for uniform mesh converter and general operations (terrapower#1042) Updating python version listed in README (terrapower#1076) Removing unused code from `calcReactionRates()` (terrapower#1084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out, in our unit tests, people have been directly accessing
._outputStreamwhen there was already a method to access that value:.getStdoutValue(). Well, let's just use that method instead.Also, I changed the name of that method to
.getStdout()to make it easier to use and added a new method, because we tend to need it a lot:.emptyStdout().NOTE: This change was chosen because it does not break any downstream code.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.