Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mockRunLogs #1101

Closed
john-science opened this issue Jan 18, 2023 · 1 comment · Fixed by #1106
Closed

Improve mockRunLogs #1101

john-science opened this issue Jan 18, 2023 · 1 comment · Fixed by #1106
Assignees
Labels
enhancement New feature or request testing Related to tests

Comments

@john-science
Copy link
Member

john-science commented Jan 18, 2023

  1. Right now, to use mockRunLogs.py in unit testing, you have to access a private member:

with mockRunLogs.BufferLog() as mock:
# we should start with a clean slate
self.assertEqual("", mock._outputStream)

Well, that seems silly. Seems to me that attribute should be public. Easy change, though it means a small PR into one downstream repo, that I can see.

  1. It is possible this tool could be more discoverable. It currently exists at armi/tests/mockRunLogs.py. Should this be in or near armi/runLogs.py?
@john-science john-science added enhancement New feature or request testing Related to tests labels Jan 18, 2023
@john-science john-science self-assigned this Jan 18, 2023
@john-science john-science linked a pull request Jan 19, 2023 that will close this issue
7 tasks
@john-science
Copy link
Member Author

It turns out we already have a helper method for this .getStdoutValues(). People just aren't using it.

So I have opened a ticket to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing Related to tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant