Cleanup umc #1099
Cleanup umc #1099
Conversation
power and pdens parameters are initially set in a neutronics run, but they may be adjusted by a gamma transport solver. Thus, these parameters should be mapped out of a uniform mesh gamma solve, even though they are also mapped in. If a gamma kernel is implemented that does not update these parameters, this converter would have to be modified and/or extended to prevent numerical diffusion of these parameters.
There was a problem hiding this comment.
Approved.
@mgjarrett @jakehader @keckler This PR worries me. It seems like this PR is only possible because we didn't do any downstream integration tests of the original Efficiency PR. Is that correct?
If it IS correct, I would like to have a quick discussion about our PR process.
Thanks!
|
To say we didn't do any integration tests is most certainly not true. We did a lot of integration testing on #1042 , and caught a lot of problems in the process before merging that. I can't speak specifically to how these particular bugs made it through, though. |
The integration tests were run, but the test result differences had not yet been reviewed in detail. These issues were caught in that review process. |
…30/assembly-1d-parent-class * terrapower/main: Adding measure of convergence for tight coupling (terrapower#1033) Fixing ruamel.yaml deprecation warning (terrapower#1109) Fix Issues with Peak Params (terrapower#1108) Adding a helper method to validate versions in settings files (terrapower#1102) Using fuelCycle settings constants (terrapower#1107) Using mockRunLogs in a better way (terrapower#1106) Using module-level neutronics settings constants (terrapower#1104) Cleanup umc (terrapower#1099) Fixing broken doc link for mpi4py (terrapower#1105) Improving logic for getNumPins (terrapower#1098) fix `code-block` sphinx errors (terrapower#1091) Defer setting material number in MCNP material card (terrapower#1086) Efficiency improvement for uniform mesh converter and general operations (terrapower#1042) Updating python version listed in README (terrapower#1076) Removing unused code from `calcReactionRates()` (terrapower#1084)
Description
Some subtle bugs in #1042 were missed until more detailed testing was performed.
block.getNumPins()andb.p.nPins.b.p.nPinsis set in the blueprints:armi/armi/reactor/blueprints/blockBlueprint.py
Line 180 in b5235f0
It also needs to be set in
_createHomogenizedCopypowerandpdensare initially set by the neutronics solver in a downstream workflow, but when gamma transport is performed these parameters are modified. Thus, they need to be mapped "out" from theGammaUniformMeshConverter. This is likely to be true of any implementation of a coupled neutronics/gamma transport solution.Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.