Improve logic for getNumPins #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewj-usnctech
added a commit
to drewj-usnctech/armi
that referenced
this pull request
Jan 23, 2023
…30/assembly-1d-parent-class * terrapower/main: Adding measure of convergence for tight coupling (terrapower#1033) Fixing ruamel.yaml deprecation warning (terrapower#1109) Fix Issues with Peak Params (terrapower#1108) Adding a helper method to validate versions in settings files (terrapower#1102) Using fuelCycle settings constants (terrapower#1107) Using mockRunLogs in a better way (terrapower#1106) Using module-level neutronics settings constants (terrapower#1104) Cleanup umc (terrapower#1099) Fixing broken doc link for mpi4py (terrapower#1105) Improving logic for getNumPins (terrapower#1098) fix `code-block` sphinx errors (terrapower#1091) Defer setting material number in MCNP material card (terrapower#1086) Efficiency improvement for uniform mesh converter and general operations (terrapower#1042) Updating python version listed in README (terrapower#1076) Removing unused code from `calcReactionRates()` (terrapower#1084)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1096
The logic for
Block.getNumPins()will identify lots of different components as pins, whether or not they are indeed pins. If a component hasFlags.SHIELD, for example, it will be considered a pin (no matter what the shape or intent of the actual component is).It is a relatively safe bet to assume all pins are circular, so a filter on component shape is applied to weed out any non-pin components.
Checklist
doc/release/0.X.rst) are up-to-date with any bug fixes or new features.docfolder.setup.py.