Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all hints of roman_datamodels units #172

Merged
merged 2 commits into from
May 11, 2023

Conversation

WilliamJamieson
Copy link
Collaborator

This PR makes the necessary changes to roman_datamodels to support spacetelescope/rad#248.

Checklist

@WilliamJamieson WilliamJamieson requested a review from a team as a code owner May 9, 2023 20:22
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (ae1caff) 96.73% compared to head (2536ea3) 96.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
- Coverage   96.73%   96.62%   -0.11%     
==========================================
  Files           9        8       -1     
  Lines        1101     1068      -33     
==========================================
- Hits         1065     1032      -33     
  Misses         36       36              
Impacted Files Coverage Δ
tests/test_stnode.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson
Copy link
Collaborator Author

The CI failures seem to be a github issue not a test failure. It seems like the action run was terminated in the middle by some GitHub error. GitHub has been experiencing CI issues for the past few days.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I have updated my L3 PRs to match this.

@WilliamJamieson
Copy link
Collaborator Author

Close/reopen to trigger CI that did not run due to GitHub system issues today.

@WilliamJamieson
Copy link
Collaborator Author

Test failures will be fixed by #174.

@PaulHuwe PaulHuwe merged commit c6f282b into spacetelescope:main May 11, 2023
@WilliamJamieson WilliamJamieson deleted the remove/units branch May 11, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants