-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all hints of roman_datamodels units #172
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 96.73% 96.62% -0.11%
==========================================
Files 9 8 -1
Lines 1101 1068 -33
==========================================
- Hits 1065 1032 -33
Misses 36 36
☔ View full report in Codecov by Sentry. |
The CI failures seem to be a github issue not a test failure. It seems like the action run was terminated in the middle by some GitHub error. GitHub has been experiencing CI issues for the past few days. |
30227e7
to
2536ea3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I have updated my L3 PRs to match this.
Close/reopen to trigger CI that did not run due to GitHub system issues today. |
Test failures will be fixed by #174. |
This PR makes the necessary changes to
roman_datamodels
to support spacetelescope/rad#248.Checklist
CHANGES.rst
under the corresponding subsection