Remove all hints of roman_datamodels units

CHANGES.rst

@@ -18,6 +18,8 @@
 
 - Bugfix for the ``amp33`` shape in ``mk_ramp``. [#166]
 
+- Remove the deprecated ``roman_datamodels.units`` module. [#172]
+
 
 0.14.2 (2023-03-31)
 ===================

pyproject.toml

@@ -18,7 +18,9 @@ dependencies = [
     'psutil >=5.7.2',
     'numpy >=1.20',
     'astropy >=5.0.4',
-    'rad >=0.14.2',
+    # 'rad >=0.14.2',
+    # Use dev version of `rad` until 0.14.2+ is released
+    'rad @ git+https://github.com/spacetelescope/rad.git@main',
     'asdf-standard >=1.0.3',
 ]
 dynamic = ['version']

src/roman_datamodels/conftest.py

@@ -1 +0,0 @@
-collect_ignore = ["units.py"]

src/roman_datamodels/extensions.py

@@ -1,12 +1,11 @@
 from asdf.extension import ManifestExtension
 
-from .stnode import TaggedListNodeConverter, TaggedObjectNodeConverter, TaggedScalarNodeConverter, UnitConverter
+from .stnode import TaggedListNodeConverter, TaggedObjectNodeConverter, TaggedScalarNodeConverter
 
 DATAMODEL_CONVERTERS = [
     TaggedObjectNodeConverter(),
     TaggedListNodeConverter(),
     TaggedScalarNodeConverter(),
-    UnitConverter(),
 ]
 
 DATAMODEL_EXTENSIONS = [

src/roman_datamodels/stnode.py

@@ -48,9 +48,6 @@
 strict_validation = True
 
 
-_UNIT_NODE_TAGS = ["asdf://stsci.edu/datamodels/roman/tags/unit-1.0.0"]
-
-
 def set_validate(value):
     global validate
     validate = bool(value)
@@ -491,21 +488,6 @@ def from_yaml_tree(self, node, tag, ctx):
         return _SCALAR_NODE_CLASSES_BY_TAG[tag](node)
 
 
-class UnitConverter(Converter):
-    tags = _UNIT_NODE_TAGS
-    types = []
-
-    def to_yaml_tree(self, obj, tag, ctx):
-        msg = "Converting to rad unit tags is no longer suppoerted. Support is now native to asdf-astropy."
-        raise NotImplementedError(msg)
-
-    def from_yaml_tree(self, node, tag, ctx):
-        from asdf_astropy.converters.unit import UnitConverter as AstropyUnitConverter
-
-        # rad unit tags are being replaced by the non-vounit tags in asdf-astropy
-        return AstropyUnitConverter().from_yaml_tree(node, "tag:astropy.org:astropy/units/unit-1.0.0", ctx)
-
-
 _DATAMODELS_MANIFEST_PATH = importlib_resources.files(rad.resources) / "manifests" / "datamodels-1.0.yaml"
 _DATAMODELS_MANIFEST = yaml.safe_load(_DATAMODELS_MANIFEST_PATH.read_bytes())
 
@@ -551,8 +533,6 @@ def _class_from_tag(tag, docstring):
         _LIST_NODE_CLASSES_BY_TAG[tag["tag_uri"]].__doc__ = docstring
     elif tag["tag_uri"] in _SCALAR_NODE_CLASSES_BY_TAG:
         _SCALAR_NODE_CLASSES_BY_TAG[tag["tag_uri"]].__doc__ = docstring
-    elif tag["tag_uri"] in _UNIT_NODE_TAGS:
-        pass
     else:
         _class_from_tag(tag, docstring)
 

tests/test_stnode.py

@@ -10,13 +10,12 @@ def test_generated_node_classes(manifest):
         class_name = stnode._class_name_from_tag_uri(tag["tag_uri"])
         node_class = getattr(stnode, class_name)
 
-        assert issubclass(node_class, (stnode.TaggedObjectNode, stnode.TaggedListNode, stnode.TaggedScalarNode, stnode.Unit))
-        if not issubclass(node_class, stnode.Unit):
-            assert node_class._tag == tag["tag_uri"]
-            assert tag["description"] in node_class.__doc__
-            assert tag["tag_uri"] in node_class.__doc__
-            assert node_class.__module__ == stnode.__name__
-            assert node_class.__name__ in stnode.__all__
+        assert issubclass(node_class, (stnode.TaggedObjectNode, stnode.TaggedListNode, stnode.TaggedScalarNode))
+        assert node_class._tag == tag["tag_uri"]
+        assert tag["description"] in node_class.__doc__
+        assert tag["tag_uri"] in node_class.__doc__
+        assert node_class.__module__ == stnode.__name__
+        assert node_class.__name__ in stnode.__all__
 
 
 def test_wfi_mode():