-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the Roman specific unit schema #248
Remove the Roman specific unit schema #248
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 4 4
Lines 124 124
=======================================
Hits 116 116
Misses 8 8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
45f5592
to
a7dc13e
Compare
This is a follow-up to #220 and spacetelescope/roman_datamodels#131. Those PRs worked to deprecate the Roman-specific non-VOunits that were introduced to support serialization of the non-VOunits from astropy, which Roman needs to serialize. Since astropy/asdf-astropy#142, the non-VOunits can now be serialized directly by
asdf-astropy
.Now that a new build of Roman is about to be released, all of the reference files will need to be regenerated. These files should now use the non-VOunit tag from
asdf-astropy
instead. Thus there is no need for the Roman-specific unit support inrad
orroman_datamodels
. This PR removes this support forrad
.Checklist
CHANGES.rst
under the corresponding subsection