Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Roman specific unit schema #248

Conversation

WilliamJamieson
Copy link
Collaborator

This is a follow-up to #220 and spacetelescope/roman_datamodels#131. Those PRs worked to deprecate the Roman-specific non-VOunits that were introduced to support serialization of the non-VOunits from astropy, which Roman needs to serialize. Since astropy/asdf-astropy#142, the non-VOunits can now be serialized directly by asdf-astropy.

Now that a new build of Roman is about to be released, all of the reference files will need to be regenerated. These files should now use the non-VOunit tag from asdf-astropy instead. Thus there is no need for the Roman-specific unit support in rad or roman_datamodels. This PR removes this support for rad.

Checklist

@WilliamJamieson WilliamJamieson requested review from kdupriestsci, jbrookens and a team as code owners May 8, 2023 15:29
@WilliamJamieson WilliamJamieson requested review from nden and schlafly May 8, 2023 15:29
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8546809) 93.54% compared to head (a7dc13e) 93.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           4        4           
  Lines         124      124           
=======================================
  Hits          116      116           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@kdupriestsci kdupriestsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine by me

Copy link
Collaborator

@ddavis-stsci ddavis-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson force-pushed the refactor/remove_roman_unit branch from 45f5592 to a7dc13e Compare May 9, 2023 19:27
@WilliamJamieson WilliamJamieson merged commit 3d213cb into spacetelescope:main May 9, 2023
@WilliamJamieson WilliamJamieson deleted the refactor/remove_roman_unit branch May 9, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants