Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for tests due to spacetelescope/rad#250 and spacetelescope/rad#258 #174

Merged

Conversation

WilliamJamieson
Copy link
Collaborator

@WilliamJamieson WilliamJamieson commented May 11, 2023

spacetelescope/rad#250 and spacetelescope/rad#258 broke some roman_datamodels tests because they were checking features by running tests on models and checking the results against the schemas. This PR updates that data.

Checklist

@WilliamJamieson
Copy link
Collaborator Author

There will be failures in the CI for this because #172 has not been merged.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +13.20 🎉

Comparison is base (c6f282b) 83.42% compared to head (5202bfa) 96.62%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #174       +/-   ##
===========================================
+ Coverage   83.42%   96.62%   +13.20%     
===========================================
  Files           8        8               
  Lines        1068     1068               
===========================================
+ Hits          891     1032      +141     
+ Misses        177       36      -141     
Impacted Files Coverage Δ
tests/test_models.py 98.20% <ø> (+18.20%) ⬆️
tests/test_stnode.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@WilliamJamieson WilliamJamieson changed the title Bug fixes for tests due to spacetelescope/rad#250 Bug fixes for tests due to spacetelescope/rad#250 and spacetelescope/rad#258 May 11, 2023
@WilliamJamieson WilliamJamieson enabled auto-merge (squash) May 11, 2023 16:25
@WilliamJamieson WilliamJamieson merged commit 3a7511a into spacetelescope:main May 11, 2023
@WilliamJamieson WilliamJamieson deleted the bugfix/for_rad_111 branch May 11, 2023 16:26
mairanteodoro pushed a commit to mairanteodoro/roman_datamodels that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants