Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make ninja shoes magboots #28586

Merged
merged 2 commits into from
Jul 14, 2024
Merged

Conversation

deltanedas
Copy link
Contributor

@deltanedas deltanedas commented Jun 4, 2024

About the PR

adds Magboots to ninja shoes (but not ItemToggle) so they always keep you on the floor no matter what

Why / Balance

fixes #28585

allows ninja to troll grav without being trolled in turn

Technical details

no

Media

jordans.mp4
  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
🆑

  • fix: Fixed ninja shoes not working as magboots.

@github-actions github-actions bot added the Changes: No C# Changes: Requires no C# knowledge to review or fix this item. label Jun 4, 2024
@Plykiya
Copy link
Contributor

Plykiya commented Jun 30, 2024

was this PR good to undraft...?

@deltanedas
Copy link
Contributor Author

item toggle rework not merged

@Plykiya
Copy link
Contributor

Plykiya commented Jul 11, 2024

item toggle rework not merged

item toggle rework got merged :^)

@deltanedas
Copy link
Contributor Author

reeeeal

@deltanedas deltanedas marked this pull request as ready for review July 11, 2024 10:21
@metalgearsloth metalgearsloth merged commit 35cd013 into space-wizards:master Jul 14, 2024
22 checks passed
@deltanedas deltanedas deleted the air-jordans branch July 14, 2024 20:34
aspiringLich pushed a commit to aspiringLich/space-station-14 that referenced this pull request Jul 21, 2024
Schrodinger71 added a commit to AdventureTimeSS14/space_station_ADT that referenced this pull request Jul 27, 2024
<!-- ЭТО ШАБЛОН ВАШЕГО PULL REQUEST. Текст между стрелками - это
комментарии - они не будут видны в PR. -->

## Описание PR
<!-- Ниже опишите ваш Pull Request. Что он изменяет? На что еще это
может повлиять? Постарайтесь описать все внесённые вами изменения! -->

## Changelog.yml
<details><summary>Лист чейнжлогов, смотреть подробнее..</summary>

```yml
- author: SlamBamActionman
  changes:
  - message: RGBee and Rainbow Carp plushies now cycle color when held/worn.
    type: Fix
  id: 6917
  time: '2024-07-14T10:26:34.0000000+00:00'
  url: space-wizards/space-station-14#30023
- author: Winkarst-cpu
  changes:
  - message: Now grappling gun is clumsy proof.
    type: Tweak
  id: 6918
  time: '2024-07-14T10:26:56.0000000+00:00'
  url: space-wizards/space-station-14#29904
- author: HahayesSiH
  changes:
  - message: It is now possible to pet cyborgs.
    type: Add
  - message: Clicking on cyborgs and opening the strip menu no longer unlocks them.
    type: Tweak
  id: 6919
  time: '2024-07-14T14:09:41.0000000+00:00'
  url: space-wizards/space-station-14#30037
- author: deltanedas
  changes:
  - message: Fixed ninja shoes not working as magboots.
    type: Fix
  id: 6920
  time: '2024-07-14T15:11:40.0000000+00:00'
  url: space-wizards/space-station-14#28586
- author: lzk228
  changes:
  - message: Scarves are eatable again.
    type: Fix
  id: 6921
  time: '2024-07-14T15:12:25.0000000+00:00'
  url: space-wizards/space-station-14#29959
- author: Winkarst-cpu
  changes:
  - message: Now addgamerule command processes only valid game rules.
    type: Fix
  id: 6922
  time: '2024-07-15T19:18:33.0000000+00:00'
  url: space-wizards/space-station-14#29912
- author: Jezithyr
  changes:
  - message: Removed the Geras ability from Slimes
    type: Remove
  id: 6923
  time: '2024-07-16T22:50:17.0000000+00:00'
  url: space-wizards/space-station-14#29731
- author: K-Dynamic
  changes:
  - message: nerfed paraylze timer of all slippable objects (including soaps, water
      puddles, and clown-related items)
    type: Tweak
  id: 6924
  time: '2024-07-16T23:26:02.0000000+00:00'
  url: space-wizards/space-station-14#27879
- author: EmoGarbage404
  changes:
  - message: Resprited wall signs.
    type: Tweak
  id: 6925
  time: '2024-07-17T04:35:19.0000000+00:00'
  url: space-wizards/space-station-14#29806
- author: lzk228
  changes:
  - message: Added health examine for caustic and cold damage.
    type: Add
  id: 6926
  time: '2024-07-17T06:19:13.0000000+00:00'
  url: space-wizards/space-station-14#29989
- author: lzk228
  changes:
  - message: Surgery saws now are normal-sized (no more pocket circular saw).
    type: Tweak
  id: 6927
  time: '2024-07-17T06:26:10.0000000+00:00'
  url: space-wizards/space-station-14#29995
- author: Winkarst-cpu
  changes:
  - message: The super door remote is now able to control Syndicate doors.
    type: Fix
  id: 6928
  time: '2024-07-17T13:50:25.0000000+00:00'
  url: space-wizards/space-station-14#30033
- author: Errant
  changes:
  - message: Vox are temporarily removed from Space Ninjas and all Unknown Shuttle
      ghostroles, until code supports giving them species-specific gear.
    type: Tweak
  id: 6929
  time: '2024-07-17T22:04:51.0000000+00:00'
  url: space-wizards/space-station-14#30099
- author: Cojoke-dot
  changes:
  - message: You can no longer teleport objects that should not be in other objects
      into other objects with the Quantum Spin Inverter
    type: Fix
  id: 6930
  time: '2024-07-18T00:40:54.0000000+00:00'
  url: space-wizards/space-station-14#29200
- author: Plykiya
  changes:
  - message: Stun batons no longer use up charges when hitting objects without stamina.
    type: Fix
  id: 6931
  time: '2024-07-18T00:48:09.0000000+00:00'
  url: space-wizards/space-station-14#30136
- author: Sh18RW
  changes:
  - message: Moth can't eat boots with an item more
    type: Fix
  id: 6932
  time: '2024-07-18T22:34:18.0000000+00:00'
  url: space-wizards/space-station-14#30019
- author: portfiend
  changes:
  - message: Reptilians display correct mask sprites in character customization screen.
    type: Fix
  id: 6933
  time: '2024-07-18T22:36:53.0000000+00:00'
  url: space-wizards/space-station-14#30095
- author: Plykiya
  changes:
  - message: You no longer deal double damage to your first target when throwing an
      item.
    type: Fix
  id: 6934
  time: '2024-07-19T01:08:52.0000000+00:00'
  url: space-wizards/space-station-14#30115
- author: deepdarkdepths
  changes:
  - message: Removed the description about geras in the Slime guidebook section.
    type: Remove
  id: 6935
  time: '2024-07-19T09:04:43.0000000+00:00'
  url: space-wizards/space-station-14#30140
- author: Blackern5000
  changes:
  - message: Nuclear operatives are now able to purchase durable armor which is NOT
      space-proof.
    type: Add
  id: 6936
  time: '2024-07-19T09:38:26.0000000+00:00'
  url: space-wizards/space-station-14#29845
- author: Plykiya, slarticodefast
  changes:
  - message: Explosive pens now correctly embed into their target.
    type: Fix
  id: 6937
  time: '2024-07-19T09:42:58.0000000+00:00'
  url: space-wizards/space-station-14#30112
- author: ThatOneEnby1337
  changes:
  - message: News Reporters are now able to use markup tags in their reports without
      bricking the PDAs of readers
    type: Fix
  id: 6938
  time: '2024-07-19T14:18:39.0000000+00:00'
  url: space-wizards/space-station-14#30169
- author: themias
  changes:
  - message: Mailing units are functional again
    type: Fix
  id: 6939
  time: '2024-07-20T02:31:26.0000000+00:00'
  url: space-wizards/space-station-14#30174
- author: Ghagliiarghii
  changes:
  - message: Nuclear Operatives' Reinforcements now have a PDA!
    type: Tweak
  id: 6940
  time: '2024-07-20T02:59:31.0000000+00:00'
  url: space-wizards/space-station-14#28088
- author: Plykiya
  changes:
  - message: Chameleon scarves now work again.
    type: Fix
  id: 6941
  time: '2024-07-20T03:00:28.0000000+00:00'
  url: space-wizards/space-station-14#30156
- author: Aidenkrz
  changes:
  - message: The mass hallucinations event no longer affects non-humanoids.
    type: Fix
  id: 6942
  time: '2024-07-20T05:53:58.0000000+00:00'
  url: space-wizards/space-station-14#28748
- author: buntobaggins
  changes:
  - message: Increased light radius on the Spationaut Hardsuit
    type: Tweak
  id: 6943
  time: '2024-07-21T03:29:21.0000000+00:00'
  url: space-wizards/space-station-14#30049
- author: EmoGarbage404
  changes:
  - message: Fixed wires not updating UI on the Particle Accelerator.
    type: Fix
  id: 6944
  time: '2024-07-21T05:27:18.0000000+00:00'
  url: space-wizards/space-station-14#28750
- author: CroilBird
  changes:
  - message: 6-pack of cola displays correctly when not being handled
    type: Fix
  id: 6945
  time: '2024-07-21T05:49:48.0000000+00:00'
  url: space-wizards/space-station-14#29309
- author: metalgearsloth
  changes:
  - message: Fix muzzle flashes not tracking properly.
    type: Fix
  id: 6946
  time: '2024-07-21T06:09:17.0000000+00:00'
  url: space-wizards/space-station-14#30163
- author: metalgearsloth
  changes:
  - message: Fix being able to throw items while your cursor is off-screen.
    type: Fix
  id: 6947
  time: '2024-07-21T06:13:28.0000000+00:00'
  url: space-wizards/space-station-14#30164
- author: metalgearsloth
  changes:
  - message: Reset the scroll bar in the ghost warp menu whenever you search for a
      role. Previously it remained at your previous position and you would have to
      scroll up to see the first entry.
    type: Tweak
  id: 6948
  time: '2024-07-21T06:38:45.0000000+00:00'
  url: space-wizards/space-station-14#30159
- author: Blackern5000
  changes:
  - message: The syndicate agent's cyborg weapons module now uses syndicate weaponry
      rather than NT weaponry.
    type: Tweak
  id: 6949
  time: '2024-07-21T07:04:33.0000000+00:00'
  url: space-wizards/space-station-14#26947
- author: Winkarst-cpu
  changes:
  - message: Added ambience to the camera routers and telecommunication servers.
    type: Add
  - message: Now server's and router's ambience stops once they are unpowered.
    type: Fix
  id: 6950
  time: '2024-07-21T07:22:02.0000000+00:00'
  url: space-wizards/space-station-14#30091
- author: Scott Dimeling
  changes:
  - message: Reduced the number of botanists in some stations, for optimal _workflow_
    type: Tweak
  id: 6951
  time: '2024-07-21T07:23:28.0000000+00:00'
  url: space-wizards/space-station-14#29581
- author: metalgearsloth
  changes:
  - message: Escape pods won't show up on shuttle map anymore.
    type: Tweak
  id: 6952
  time: '2024-07-21T07:23:44.0000000+00:00'
  url: space-wizards/space-station-14#29758
- author: IProduceWidgets
  changes:
  - message: an arabian lamp!
    type: Add
  id: 6953
  time: '2024-07-21T07:24:28.0000000+00:00'
  url: space-wizards/space-station-14#27270
- author: osjarw
  changes:
  - message: NPCs no longer get stuck trying to pick up anchored pipes.
    type: Fix
  id: 6954
  time: '2024-07-21T07:28:37.0000000+00:00'
  url: space-wizards/space-station-14#30061
- author: The Hands Leader - JoJo cat
  changes:
  - message: Train map is back into rotation
    type: Tweak
  id: 6955
  time: '2024-07-21T07:44:18.0000000+00:00'
  url: space-wizards/space-station-14#30145
```

</details>


**Медиа**
<!-- Если приемлемо, добавьте скриншоты для демонстрации вашего PR. Если
ваш PR представляет собой визуальное изменение, добавьте
скриншоты, иначе он может быть закрыт. -->

**Проверки**
<!-- Выполнение всех следующих действий, если это приемлемо для вида
изменений сильно ускорит разбор вашего PR -->
- [ ] PR полностью завершён и мне не нужна помощь чтобы его закончить.
- [ ] Я внимательно просмотрел все свои изменения и багов в них не
нашёл.
- [ ] Я запускал локальный сервер со своими изменениями и всё
протестировал.
- [ ] Я добавил скриншот/видео демонстрации PR в игре, **или** этот PR
этого не требует.

**Изменения**

:cl: Шрёдька
- tweak: Подтянуты коммиты с корвакса, 27.07.24
themias pushed a commit to themias/space-station-14 that referenced this pull request Aug 9, 2024
Baa14453 pushed a commit to Baa14453/space-station-14 that referenced this pull request Oct 19, 2024
SlamBamActionman added a commit to SlamBamActionman/space-station-14 that referenced this pull request Nov 1, 2024
* VGRoid support (space-wizards#27659)

* Dungeon spawn support for grid spawns

* Recursive dungeons working

* Mask approach working

* zack

* More work

* Fix recursive dungeons

* Heap of work

* weh

* the cud

* rar

* Job

* weh

* weh

* weh

* Master merges

* orch

* weh

* vgroid most of the work

* Tweaks

* Tweaks

* weh

* do do do do do do

* Basic layout

* Ore spawning working

* Big breaking changes

* Mob gen working

* weh

* Finalising

* emo

* More finalising

* reverty

* Reduce distance

* New anomaly behaviour: Invisibility (space-wizards#29120)

* invisible anomaly

* good luck

* Automatic changelog update

* feat: allow developers to customize vscode settings, closes space-wizards#29285 (space-wizards#29294)

* Allow construction of rotated railings (space-wizards#29687)

* Remove southRotation from railing structures

* Curly Braces

* Automatic changelog update

* improved wrench description (space-wizards#29700)

Lefty latchy, righty removey

* add apc power draw to stat value command (space-wizards#29701)

add apc stat value

* Dynamic Radial Menus (space-wizards#29678)

* fix

* Clean Some Code

* Some Commentaries

* Update Content.Client/UserInterface/Controls/RadialContainer.cs

* Update Content.Client/UserInterface/Controls/RadialContainer.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Automatic changelog update

* Fixes objects changing physics behavior after being pulled (space-wizards#29694)

* Fixes pull rotation logic

* cleaner condition

* even less code

* I CHANGED MY MIND

* first one

* second one

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Automatic changelog update

* Makes portable flashers destructable (space-wizards#29564)

Makes portable flashers destructible

Co-authored-by: plykiya <plykiya@protonmail.com>

* Automatic changelog update

* Starting gear for vox crewmembers (space-wizards#29685)

* tank harness

* weh

* Suit Storage Whitelist

* Revert "Suit Storage Whitelist"

This reverts commit b1f5035.

* suit storage filter

* vox spawn gear

* weh

* Make all nukies humans (space-wizards#29693)

* Automatic changelog update

* Make vox roundstart (space-wizards#29704)

* Make vox roundstart

I believe all the issues are fixed.

* Click detection bandaid

* Automatic changelog update

* Added Health Analyzer to basic treatment module. (space-wizards#29696)

Removed dropped, added Health Analyzer to Basic Treatment Module

Co-authored-by: JIP <jipdawg93@gmail.com>

* Automatic changelog update

* Fix animation looping bugs. (space-wizards#29457)

Summary of the problem is in the corresponding engine commit: space-wizards/RobustToolbox@a4ea5a4

This commit requires engine master right now.

I think space-wizards#29144 is probably the most severe one, but I touched Jittering and RotatingLight too since they seemed sus too.

Fixes space-wizards#29144

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>

* Automatic changelog update

* fix(marathon): Fixing more issues (space-wizards#29411)

* fix(packed): Fix a couple of issues (space-wizards#29422)

* fix(packed): Fix a couple of issues

* Name the signal button for bar

* Fix Vox clothing in character creation menu (space-wizards#29709)

Update vox.yml

* Fix typo in pineapple pizza description (space-wizards#29714)

* Move checking code for BlacklistedRange to the right place in sqlite (space-wizards#29389)

* Re-enabling nukie species(except vox), added antag species blacklisting

* Revert "Make all Nukies humans (space-wizards#29693)"

This reverts commit 3e3e050.

* Implemented species blacklist

* Re-enabled all species as Nukies except for Vox because loadouts don't support breathing alternative gases yet.

* Automatic changelog update

* Add summary comments for ElectrifiedComponent fields (space-wizards#29733)

add summaries for ElectrifiedComponent

* Fix showing the inventory button on entities without any inventory slots (space-wizards#29728)

* Fire Axe resprite 45 degrees v3 (space-wizards#28866)

Rotating Fire Axe 45 deg

* nuke biochem (space-wizards#29751)

Nuke biomchem again

* Shuttle map button tweaks (space-wizards#29757)

- Avoids adding pending objects we can never show so the list should fill much faster.

* Automatic changelog update

* Don't allow toggling internals while asleep (space-wizards#29753)

* You no longer get deleted when cuffed and buckled (space-wizards#29718)

fix

* Fixes a minor typo for the base gingerbread body part (space-wizards#29717)

"Fixes a minor typo in the gingerbread bodypart prototype"

* Phoronman 1984 (space-wizards#29747)

No more.

* Added cryosleep UnitSpawner and UnitSpawnerLate to the map Origin (space-wizards#29761)

Added cryosleep UnitSpawner and UnitSpawnerLate

Co-authored-by: JIP <jipdawg93@gmail.com>

* Automatic changelog update

* Fix wielding while pulling (space-wizards#29781)

* Update Credits (space-wizards#29784)

Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>

* Spilling reagents on mutliple entities at once fix (space-wizards#29763)

* Fixed!

* That could have been bad this is why I'm glad I check the diff xD

* Automatic changelog update

* Improve buckling's interactions with standing state (space-wizards#29741)

* Automatic changelog update

* Add supplybot moving states (space-wizards#29795)

* Add supplybot moving states

* forgor

* Raise ratking migration minimum players to 30 from 15 (space-wizards#29737)

* Automatic changelog update

* Intercom buffs and fixes (space-wizards#29580)

* Intercom buffs and fixes

* remove unused bui state

* mild sec intercom buff

* reinforce sec intercoms

* Automatic changelog update

* Bartending+: Shaking and Stirring (space-wizards#29243)

* Shaking and Stirring

* Remove shake message

* Switch if order a bit

* Add doafter supprot for reactionmixer

* Fix nullability

* Timespan zero

* Forgot to remove loc string

* Reorganize usings

* Remove unneeded usings, fix b52 needing to be shaken

* Slicing food with Swords (space-wizards#29005)

* added utensil component

* BaseSword added

* fix(hardsuits): Give the carp suit and hardsuit a suit storage slot (space-wizards#29322)

* fix(hardsuits): Give the carp hardsuit suit storage

* Both carpsuits have suit slots

* Automatic changelog update

* metal foam grenades (space-wizards#29428)

* metal foam grenades

* wow okay

* meh

* bruh

* test

* push

* The real AME nerf (space-wizards#29587)

* The real AME nerf

* oh the real change

* Update AmeNodeGroup.cs

* Removes max damage threshold on healing for hyperzine (space-wizards#29712)

* Removes max damage threshold for hyperzine

* the description...

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Automatic changelog update

* Silence ringtones on admin PDAs (space-wizards#29801)

* Silence ringtones on invisible PDAs

* Revert "Silence ringtones on invisible PDAs"

This reverts commit afc1041.

* Literally just this

* Add an admin announcement for news article publishing

* Automatic changelog update

* Fixed the guide book entry for Diona's blood type (space-wizards#29805)

Fixed the entry for Diona's blood type

Co-authored-by: JIP <jipdawg93@gmail.com>

* Improve throwing precision (space-wizards#29726)

* improve throwing precision

* remove debugging logs

* minor fixes

* f

* Update Content.Shared/Throwing/LandAtCursorComponent.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Automatic changelog update

* Don't treat vgroid as station grid (space-wizards#29811)

Forgot I added this toggle.

* Vox guidebook entry (space-wizards#29713)

* vox guidebook entry

* skreee

* Removed incorrect diet reference

* Automatic changelog update

* Restore a panic bunker cvar in wizardsDen.toml (space-wizards#29832)

Update wizardsDen.toml

* all toggle light actions have a 1 second use delay (space-wizards#29833)

* Automatic changelog update

* Fix Shotgun Spam Loading (space-wizards#29827)

* Automatic changelog update

* Add popup for healing target (space-wizards#29804)

* Add popup for healing target

* hop

* huh

* fix one

* fix showing popup to all

* Add popup for health analyzer target (space-wizards#29803)

* Add popup for health analyzer target

* addition

* fix showing popup to all

* localization and change of appearance of the phrase about the remaining time (space-wizards#29844)

* Action menu localization (space-wizards#29839)

* fix passive vent sprite in construction menu (space-wizards#29820)

* Automatic changelog update

* Let Pacifists Use Certain Guns(Foam Weapons) (space-wizards#29835)

Let Pacifists Use Certain Guns(foam)

* Automatic changelog update

* Fix lobby time typo (space-wizards#29841)

* Localization of the threat level in an emergency lamp (space-wizards#29847)

* Nozzle Direction Localization (space-wizards#29849)

* Aghosts can now /ghost (space-wizards#29360)

I will not be subjected to criminal abuse

* Change Cluster evac (space-wizards#29828)

* Update map changes labeler (space-wizards#29858)

Update labeler.yml

* Stop eating food if you drop it (space-wizards#29854)

* Stop eating food if you drop it

* woops, unused param

* comments

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Automatic changelog update

* Fix colornetwork desc and help (space-wizards#29856)

* Fix colornetwork description

* suggested changes

* forgor

* done

* ok now it IS done

* made the guitars be able to be worn on suitstorage (space-wizards#29048)

* made the guitars be able to be worn on suitstorage

* minor fix

* Automatic changelog update

* Fix borg's popup spam (space-wizards#29861)

Fix borg popup spam

Co-authored-by: Winkarst-cpu <Winkarst@users.noreply.github.com>

* Automatic changelog update

* Steal Objective Condition now support stacks (space-wizards#29843)

* Update StealConditionSystem.cs

* Update StealConditionSystem.cs

* fixed missing characters in OwO accent (space-wizards#29047)

replaced two characters with ones that actually show up ingame

* Add scarf to warm clothing bounty (space-wizards#29779)

* Add scarf to warm clothing bounty

* Added ClothingScarfBase prototype and assigned to all of the scarves

* Automatic changelog update

* Add an option to the admin fax menu to lock papers such that they can't be edited by cybersun pens (space-wizards#28972)

* Add option to adminfax for locking papers.

* Replace dummy control with margin

* Automatic changelog update

* books bag tabletop (space-wizards#29863)

* books bag tabletop

* Update Resources/Prototypes/Entities/Objects/Specific/Librarian/books_bag.yml

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Fix typing indicators! (space-wizards#29492)

* First commit

* Removed pause stuff

* Make the event better

* Forgot to add the comment

* Proto id stuff

* cool comments

* serializer

* Added the time stuff

* Crafting pizza boxes. (space-wizards#29680)

* We can now craft pizza boxes

* Fixing errors

* Automatic changelog update

* Custom solution transfer volume popup and item status panel fix (space-wizards#29852)

* Fix for custom solution transfer volume

* Dirty call to prevent issues

* Another fix, git issue

---------

Co-authored-by: Winkarst-cpu <Winkarst@users.noreply.github.com>

* Automatic changelog update

* Fixed jobwhitelist locale (space-wizards#29878)

Fixed whitelist locale

* Update Core (space-wizards#29880)

add

* Replace ProtoId<EntityPrototype> uses with EntProtoId (space-wizards#29892)

* Character menu asks if you want to save your character on exit (space-wizards#29875)

* Character menu asks if you want to save your character on exit

* Fix

* Another fix, little mistake by me

* Update Content.Client/Lobby/UI/CharacterSetupGuiSavePanel.xaml.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Automatic changelog update

* Revert Baby Jail (space-wizards#29891)

* Revert "SS14-28662 Add Baby Jail: a Jail for Babies (inverse panic bunker) (space-wizards#28763)"

This reverts commit 3ceb92a.

* Revert configs

* Oops

* Allow attack while pulling (space-wizards#29703)

* Make VirtualItem not block attacking

* Remove unneeded usings

* Automatic changelog update

* Fix baby jail (space-wizards#29896)

* Revert "Revert Baby Jail (space-wizards#29891)"

This reverts commit 24a2866.

* the fix

* Fix the ability to shoot out of crates (space-wizards#28961)

* Fix the ability to shoot out of crates

* Makes it check what inventory the player is in

* use IsEntityOrParentInContainer

* Fix Issues Github had

* gaahhh... Prevents lasers from being shot out of crates

* gaahhh... Prevents lasers from being shot out of crates

* Fix laser?

* hmmm... this is better looking I think?

* Uncook indentation

* Rerun tests?

* Automatic changelog update

* Glass Airlocks In Spray Painter (space-wizards#29869)

* Automatic changelog update

* Picking a ghostrole as an admin will now deadmin you. (space-wizards#29790)

* @Forcibly deadmins you

* Added checks for AdminDeadminOnJoin

* Automatic changelog update

* item toggling giga rework + full ninja refactor (space-wizards#28039)

* item toggle refactoring and some new systems

* add ToggleClothing component/system

* unhardcode magboots gravity logic

* make magboots and speedboots use ItemToggle and stuff

* remove now useless clothing components

* update client/server magboots systems

* add note to use ItemToggledEvent in ToggleActionEvent doc

* refactor PowerCellDraw to use ItemToggle for ui open/close control

* add TryUseCharges, refactor charges system

* update magboot trigger code

* make borg use ItemToggle, network SelectedModule instead of now removed Activated

* add AccessToggle for borg

* the giga ninja refactor

* update ninja yml

* update ItemToggle usage for some stuff

* fix activatableui requires power

* random fixing

* yaml fixing

* nuke ItemToggleDisarmMalus

* make defib use ItemToggle

* make things that use power not turn on if missing use charge

* pro

* fix sound prediction

* bruh

* proximity detector use ItemToggle

* oop

* big idiot syndrome

* fix ninja spawn rule and make it generic

* fix ninja spawn rule yml

* move loading profiles into AntagLoadProfileRule

* more ninja refactor

* ninja yml fixes

* the dreaded copy paste ops

* remove useless NinjaRuleComponent and ue AntagSelection for greeting

* fix invisibility

* move IsCompleted to SharedObjectivesSystem

* ability fixes

* oop fix powercell instantly draining itself

* sentient speedboots gaming

* make reflect use ItemToggle

* fix other test

* loadprofilerule moved into its own pr

* remove conflict with dragon refactor

* remove all GenericAntag code from ninja

* )

* probably

* remove old enabled

* great language bravo vince

* GREAT LANGUAGE

* who made this language

* because it stinks

* reparent blood-red magboots to magboots probbbly works

* most of the review stuff

* hasGrav doesnt mean what i thought it did

* make health analyzer use itemtoggle, not fail test

* fix mag/speed boots being wacky

* UNTROLL

* add ItemToggle to the random health analyzers

* a

* remove unused obsolete borg func

* untrolling

* :trollface:

* fix test

* fix

* g

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Fix AtmosDeviceSystem debug assert Heisenbug (space-wizards#29752)

Fix AtmosDeviceSystem debug assertion Heisenbug

* Revert "Picking a ghostrole as an admin will now deadmin you. (space-wizards#29790)" (space-wizards#29901)

This reverts commit 1a50760.

* Аnnouncement sender localization (space-wizards#29907)

* Better admin note popups text visibility (space-wizards#29909)

* Better admin note popup text visibility

* Bring buttons closer to the border

* Automatic changelog update

* Update cluster evac (space-wizards#29885)

* Update cluster evac

* forgot tiny fans

* the change

* Update FloorTileSystem to not use Component.Owner() (space-wizards#29930)

* Update FloorTileSystem to use EntityUid

* missed a variable

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Made musket wieldable. (space-wizards#29910)

* Made musket wieldable.

* Updated musket rsi meta.json copyright.

* Copyright adjustment again.

* Automatic changelog update

* Allow notice boards to be built on walls (space-wizards#29851)

* Make stun batons be thrown like a throwing weapon (space-wizards#29883)

* make stun batons be thrown like a throwing weapon

* stun prods too

* pies too

* Automatic changelog update

* Update RCDSystem.cs to not use Component.Owner (space-wizards#29940)

Update RCDSystem.cs

Co-authored-by: plykiya <plykiya@protonmail.com>

* Update MapScreen.xaml.cs to not use Component.Owner (space-wizards#29938)

Update MapScreen.xaml.cs

Co-authored-by: plykiya <plykiya@protonmail.com>

* Update BiomeSystem.cs to not use Component.Owner (space-wizards#29939)

Update BiomeSystem.cs

Co-authored-by: plykiya <plykiya@protonmail.com>

* Fixes dropping item in container (space-wizards#29900)

* Items droped in containers will end up in containers

* Adds integration test for dropping entity while inside container

* comment

* comment

* trim the diff

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Localization of dungeon direction (space-wizards#29911)

* Automatic changelog update

* Throwing system hotfix (space-wizards#29935)

throwing system hotfix

* Automatic changelog update

* Fix supplybot movement state (space-wizards#29944)

Fix supplybot movement sprite

* Implement Health Consideration for NPCs (space-wizards#29922)

Implement TargetHealthCon

* Fix timer deconstruction (space-wizards#29917)

Fix deconstruction for timers

* Automatic changelog update

* Updates GasTankSystem and InternalsSystem to not use Component.Owner (space-wizards#29934)

* blah, setup

* Updates GasTankSystem and InternalsSystem to not use Component.Owner

* squish the diff

* Fixa the rest

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Centered hard hat sprites (space-wizards#29953)

* Automatic changelog update

* Update UtensilSystem.cs to not use Component.Owner (space-wizards#29971)

Update UtensilSystem.cs

Co-authored-by: plykiya <plykiya@protonmail.com>

* Update TriggerSystem.TimedCollide.cs to not use Component.Owner (space-wizards#29970)

Update TriggerSystem.TimedCollide.cs

Co-authored-by: plykiya <plykiya@protonmail.com>

* Change whitelist to pass when null (space-wizards#29981)

* Use reinforced glass damage modifier for secure windoors (space-wizards#29941)

* Use Rglass damage modifier for reinforced windoors

* i actually can remove this line since inherited

* Automatic changelog update

* Add doc comments to target action components (space-wizards#29982)

* Update ShuttleDockControl.xaml.cs to not use Component.Owner (space-wizards#29966)

Update ShuttleDockControl.xaml.cs

Co-authored-by: plykiya <plykiya@protonmail.com>

* Update ActionAlertTooltip.cs to use TryFromMarkup (space-wizards#29975)

* Update SmokingSystem.SmokingPipe.cs to not use Component.Owner (space-wizards#29967)

Update SmokingSystem.SmokingPipe.cs

Co-authored-by: plykiya <plykiya@protonmail.com>

* Fix antag objectives always overshooting MaxDifficulty (and kill tries20) (space-wizards#29830)

* The death of try20

* Add integration test for traitor gamerule

* Fix max difficulty being overshot

* Check at least one objective is assigned

* EntProtoId

* Automatic changelog update

* fire extinguisher using item toggle (space-wizards#29906)

* move SprayAttemptEvent to shared

* add SolutionTransferredEvent

* replace FireExtinguisher with SpraySafety

* update fire extinguisher yml

* invert visuals

* always handle event in solution transfer, it makes popups

* instantly fill it

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Update SalvageSystem.Magnet to not use Component.Owner (space-wizards#29961)

* Update SalvageSystem.Magnet.cs

* Update SalvageSystem.Magnet.cs the right way

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Update submodule to 228.0.0 (space-wizards#29947)

* Update submodule to 228.0.0

* Fix every single test

* Also this one

* Dummy vox deserves a proper vox name (space-wizards#29789)

SKREEEEEeeeeeeee

* Watches (space-wizards#29550)

* watches

* rename

* add it into loot pools

* Remove imagesharp and StatusEffectAddedEvent from FlashOverlay (space-wizards#28930)

remove imagesharp and StatusEffectAddedEvent from FlashOverlay

* Automatic changelog update

* make cargo balance ui updating its own component (space-wizards#28295)

* add BankClientComponent and event

* query BankClient instead of hardcoded CargoOrderConsole for updating

* add BankClient to all ordering consoles

* :trollface:

* add Balance field to BankClient

* forgor

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

* m

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

* fix(SharedGunSystem): Return and debug log on CreateEffect. (space-wizards#29656)

Sometimes CreateEffect is called on a Invalid Entity. This now causes
that to check, thus returning out and printing some hopefully helpful
logs to try to track down the real source of this issue.

* Replace DetachParentToNull() with DetachEntity() (space-wizards#29992)

DETACH PARENT TO ENTITY

Co-authored-by: plykiya <plykiya@protonmail.com>

* Update SpawnAfterInteractSystem.cs to not use Component.Owner (space-wizards#29968)

* Update SpawnAfterInteractSystem.cs

* what the fuck is that condition

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Shiny Diamonds (space-wizards#25750)

* shiny

* add

* reresprite

* rereresprite

* Add files via upload

* Update ore.yml

* Automatic changelog update

* Vgroid diamonds hotfix (space-wizards#29999)

vgroid diamonds

* Update RadiationPulseOverlay.cs to have 0 warnings (space-wizards#30004)

* New CDN publish workflow (space-wizards#30009)

* LET'S SEE IF THIS WORKS

* I forgot the chmod +x

* I forgot the shebang

* Remove outdated steps from Test Packaging workflow (space-wizards#30018)

gen build info was removed in 5e800e0 but I didn't realize this workflow also tested it. Gone now.

* Replace obsolete xform.ToMap() with xformSystem.ToMapCoordinates() (space-wizards#30010)

* Get rid of a bunch of obsolete usages

* position

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Replace obsolete EntityCoordiates.InRange() with TransformSystem.InRange() (space-wizards#29993)

* Replace EntityCoordiates.InRange() with TransformSystem.InRange()

* nullspace

* I figured it out

* man I have no clue how client side sutff works

* please have mercy

* remove RadiationPulseOverlay changes

* nullspace

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* Update IdExaminableSystem.cs to use TryFromMarkup (space-wizards#29957)

* Change FromMarkup to TryFromMarkup method in IdExaminableSystem.cs

* Update

* Update changelog RSS configuration (space-wizards#30024)

New server

* Update Credits (space-wizards#30026)

Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>

* Fix lizards losing snouts when equipping a head bandana (space-wizards#29979)

* say goodbye to no-snout lizards

* remove snout from plague doctor hat HideLayerClothing component

* Automatic changelog update

* Update MainMenu.cs to use ISawmill (space-wizards#29988)

* Update MainMenu.cs to use ISawmill

* Update

* Error

* NPC exits MeleeOperator on invalid EntityUid (space-wizards#30005)

EntityUid 0 problem fix

* Clean itemmapper (space-wizards#29983)

* File scoped namespace

* Format file

* Fix param name in doc comment

* Reflow doc comment

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update AccessLevelControl.xaml.cs to use ISawmill (space-wizards#29987)

* Update AccessLevelControl.xaml.cs to use ISawmill

* Update

* Silly me

* Update

* Fix AGhostCommand naming (space-wizards#29945)

* Change wristwatch meta description (space-wizards#30036)

* Fix RGB toys color when worn/in-hand (space-wizards#30023)

rgbeeeeeeee

* Clumsy proof grappling gun (space-wizards#29904)

Make grappling gun clumsy proof

* Automatic changelog update

* Fix HTN/NPC better plan selection (space-wizards#30017)

* recording commit

* Remove debugging/recording content

* Ambient music rules refactor (space-wizards#29921)

* refactor

* dutypo

* Prevent virtual item storage and popups (space-wizards#30020)

* Prevent virtual item storage and popups

* fix typo

* add comment

* Add petting cyborgs (space-wizards#30037)

added petting borgs, adjusted interactions

* Automatic changelog update

* make ninja shoes magboots (space-wizards#28586)

Co-authored-by: deltanedas <@deltanedas:kde.org>

* make scarves eatable again (space-wizards#29959)

* Automatic changelog update

* Fix AccessLevelControl breaking (space-wizards#30045)

space-wizards#29987 did an oopsie

This broke the ID computer, station records, and maybe some others too.

* Update host key for changelog RSS (space-wizards#30068)

* Fix invalid UI hover/click sounds breaking client (space-wizards#30067)

fixes space-wizards#29561

* Fix some markup related obsolete warnings in research and anomaly related systems (space-wizards#30072)

Fix some Markup related obsolete warnings in Research and Anomaly related systems

* Make addgamerule command process only valid game rules (space-wizards#29912)

* addgamerule command processes only valid rules

* Update

* English moment

* Automatic changelog update

* Add missing command description to replay_toggleui (space-wizards#30071)

* Remove uses of AllObjectives (space-wizards#30077)

Remove the uses of AllObjectives

* Revert "Change wristwatch meta description" (space-wizards#30070)

Revert "Change wristwatch meta description (space-wizards#30036)"

This reverts commit 919b3ac.

* Replace EntityPrototype.NoSpawn with EntityPrototype.HideSpawnMenu (space-wizards#30082)

NoSpawn

Co-authored-by: plykiya <plykiya@protonmail.com>

* Remove Geras from Slimes to address combat balance (space-wizards#29731)

Removed Geras

Removed Geras

* Automatic changelog update

* Nerf & standardised slip times (space-wizards#27879)

* standardised slip times

* puddle and gib soap

* banana peels

* cleaned yaml by shifting to component

* error slip

* error slip intersect

* intersect ratio return

* error and omega soap changes

* SlipocalypseClusterSoap 2 tc cost

* Automatic changelog update

* Sign Resprite (space-wizards#29806)

* Redone signage

* Signs

* ok this thing now

* alright ig?

* big data

* cryo sign

* new sign

* Automatic changelog update

* Character menu issuer localization (space-wizards#29840)

* Update CharacterUIController.cs

* TODO Burn this shit

* huh?

* huh!

---------

Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>

* Add examine for caustic and cold damage (space-wizards#29989)

* Examinable cold damage

* lightblue

* update grammar

* caustic

* Automatic changelog update

* Little saw debuff (space-wizards#29995)

* Automatic changelog update

* Vox displacement updates (space-wizards#29824)

* more vox displacement maps

* A

* remove vox insuls sprites

* sci magboots

* Update vox.yml

* Update meta.json

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>

* Make the super door remote to be able to control Syndicate doors (space-wizards#30033)

* Make the super door remote to be able to control Syndicate doors

* Fix

* Automatic changelog update

* Fix formatting warnings (space-wizards#30122)

* Temporarily remove Vox from space ninja and Unknown Shuttle ghostroles (space-wizards#30099)

* no vox ninjas

* blacklist vox from UnknownShuttleEvent

* Automatic changelog update

* DungeonSystem.Rooms bugfix (space-wizards#30125)

Update DungeonSystem.Rooms.cs

* Updated slime storage capacity text in guidebook (space-wizards#30121)

* Prevent Quantum Spin Inverter from Teleporting Things into Microwaves (space-wizards#29200)

* Prevent Quantum Spin Inverter from Teleporting Things into Microwaves

* Simplifies code, GetTeleportingEntity instead of TryGet, adds failed teleport message

* remove using Linguini.Syntax.Ast;

* capital...

* re-add CanInsert and Fixes microwave issue

* beb

* beeb

* minor SharedInteractionSystem cleanup (space-wizards#30139)

cleanup SharedInteractionSystem

* Automatic changelog update

* Fix stun batons using excess charges when thrown (space-wizards#30136)

Fix stun batons

Co-authored-by: plykiya <plykiya@protonmail.com>

* Automatic changelog update

* fix(dev_map): resave dev map (space-wizards#30098)

fix(dev_map): Resave devmap

Co-authored-by: 4llv07e <igor@c4llv07e.xyz>

* Correct .editorconfig to use no space after casting (space-wizards#30132)

* LatheSystem independently of energy (space-wizards#30148)

* Update LatheSystem.cs

* Emo

* Add dwarves (space-wizards#62)

* Revert "Revert "Change wristwatch meta description" (space-wizards#30070)"

This reverts commit 2e3d2db.

* Fix build error num. 1

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: Alex Pavlenko <diraven@users.noreply.github.com>
Co-authored-by: ArkiveDev <95712736+ArkiveDev@users.noreply.github.com>
Co-authored-by: Interrobang01 <113810873+Interrobang01@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: Rinary <72972221+Rinary1@users.noreply.github.com>
Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com>
Co-authored-by: plykiya <plykiya@protonmail.com>
Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
Co-authored-by: JIPDawg <51352440+JIPDawg@users.noreply.github.com>
Co-authored-by: JIP <jipdawg93@gmail.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
Co-authored-by: Brandon Hu <103440971+Brandon-Huu@users.noreply.github.com>
Co-authored-by: jmcb <joelsgp@protonmail.com>
Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com>
Co-authored-by: Jezithyr <jezithyr@gmail.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: DrSmugleaf <10968691+DrSmugleaf@users.noreply.github.com>
Co-authored-by: AndreyCamper <andrey.udaltzov2010@ya.ru>
Co-authored-by: end <72604018+laok233@users.noreply.github.com>
Co-authored-by: themias <89101928+themias@users.noreply.github.com>
Co-authored-by: Killerqu00 <47712032+Killerqu00@users.noreply.github.com>
Co-authored-by: MFMessage <22904993+MFMessage@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: Verm <32827189+Vermidia@users.noreply.github.com>
Co-authored-by: NotSoDamn <75203942+NotSoDana@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
Co-authored-by: Whisper <121047731+QuietlyWhisper@users.noreply.github.com>
Co-authored-by: Cojoke <83733158+Cojoke-dot@users.noreply.github.com>
Co-authored-by: chavonadelal <156101927+chavonadelal@users.noreply.github.com>
Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com>
Co-authored-by: Winkarst-cpu <74284083+Winkarst-cpu@users.noreply.github.com>
Co-authored-by: Winkarst-cpu <Winkarst@users.noreply.github.com>
Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
Co-authored-by: Ivan <69372103+lokachop@users.noreply.github.com>
Co-authored-by: dffdff2423 <dffdff2423@gmail.com>
Co-authored-by: Ghagliiarghii <68826635+Ghagliiarghii@users.noreply.github.com>
Co-authored-by: saga3152 <133799418+saga3152@users.noreply.github.com>
Co-authored-by: Tunguso4ka <71643624+Tunguso4ka@users.noreply.github.com>
Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com>
Co-authored-by: Vasilis <vasilis@pikachu.systems>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: Jonathan Argo <jonathan.argo@gmail.com>
Co-authored-by: osjarw <62134478+osjarw@users.noreply.github.com>
Co-authored-by: CaasGit <87243814+CaasGit@users.noreply.github.com>
Co-authored-by: Luiz Costa <33888056+luizwritescode@users.noreply.github.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
Co-authored-by: CookieMasterT <124045269+CookieMasterT@users.noreply.github.com>
Co-authored-by: K-Dynamic <20566341+K-Dynamic@users.noreply.github.com>
Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com>
Co-authored-by: kbailey-git <84491830+kbailey-git@users.noreply.github.com>
Co-authored-by: 4llv07e <igor@c4llv07e.xyz>
Co-authored-by: LankLTE <135308300+LankLTE@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Changes: Requires no C# knowledge to review or fix this item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space ninja shoes' magnetic suction cups aren't magnetic
3 participants