Throwing system hotfix #29935
Merged
Throwing system hotfix #29935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone check if I did the changelog template for multiple contributors correctly? |
aspiringLich
pushed a commit
to aspiringLich/space-station-14
that referenced
this pull request
Jul 21, 2024
throwing system hotfix
Schrodinger71
added a commit
to AdventureTimeSS14/space_station_ADT
that referenced
this pull request
Jul 26, 2024
<!-- ЭТО ШАБЛОН ВАШЕГО PULL REQUEST. Текст между стрелками - это
комментарии - они не будут видны в PR. -->
## Описание PR
<!-- Ниже опишите ваш Pull Request. Что он изменяет? На что еще это
может повлиять? Постарайтесь описать все внесённые вами изменения! -->
## Changelog.yml
```yml
- author: ShadowCommander
changes:
- message: Players can now use melee attacks and shoves while dragging an entity
in their active hand.
type: Tweak
id: 6900
time: '2024-07-11T04:48:00.0000000+00:00'
url: space-wizards/space-station-14#29703
- author: Cojoke-dot
changes:
- message: You can no longer shoot out of crates with guns
type: Fix
id: 6901
time: '2024-07-11T05:14:49.0000000+00:00'
url: space-wizards/space-station-14#28961
- author: Cojoke-dot
changes:
- message: The Spray Painter can now be used to paint glass airlocks to look like
regular glass airlocks.
type: Tweak
id: 6902
time: '2024-07-11T05:33:20.0000000+00:00'
url: space-wizards/space-station-14#29869
- author: MFMessage
changes:
- message: Picking a ghost role as an admin will now deadmin.
type: Fix
id: 6903
time: '2024-07-11T05:53:15.0000000+00:00'
url: space-wizards/space-station-14#29790
- author: Winkarst-cpu
changes:
- message: Admin notes popups are now more readable.
type: Tweak
id: 6904
time: '2024-07-11T14:03:22.0000000+00:00'
url: space-wizards/space-station-14#29909
- author: jonathanargo
changes:
- message: Muskets are now wieldable.
type: Tweak
id: 6905
time: '2024-07-12T09:16:21.0000000+00:00'
url: space-wizards/space-station-14#29910
- author: themias
changes:
- message: Notice boards can now be built on walls
type: Fix
id: 6906
time: '2024-07-12T09:18:32.0000000+00:00'
url: space-wizards/space-station-14#29851
- author: slarticodefast
changes:
- message: Stun batons, stun prods and banana cream pies now fly like other throwing
weapons when thrown.
type: Fix
id: 6907
time: '2024-07-12T09:19:24.0000000+00:00'
url: space-wizards/space-station-14#29883
- author: Plykiya
changes:
- message: Dropping an item while in a container now places the item in the container.
type: Fix
id: 6908
time: '2024-07-12T09:24:08.0000000+00:00'
url: space-wizards/space-station-14#29900
- author: coffeeware, slarticodefast
changes:
- message: Fixed items thrown very fast not being in the air. In particular this
fixes the pneumatic cannon.
type: Fix
- message: Buffed base hand throwing speed by 10% to be more similar to before the
recent throwing changes.
type: Tweak
id: 6909
time: '2024-07-12T10:32:47.0000000+00:00'
url: space-wizards/space-station-14#29935
- author: themias
changes:
- message: Timers can now be deconstructed
type: Fix
id: 6910
time: '2024-07-12T11:38:59.0000000+00:00'
url: space-wizards/space-station-14#29917
- author: jonathanargo
changes:
- message: Hard hat icon sprites are now centered correctly.
type: Fix
id: 6911
time: '2024-07-12T15:00:40.0000000+00:00'
url: space-wizards/space-station-14#29953
- author: lzk228
changes:
- message: Secure windoors now use reinforced glass damage modifier.
type: Fix
id: 6912
time: '2024-07-13T04:03:16.0000000+00:00'
url: space-wizards/space-station-14#29941
- author: Tayrtahn
changes:
- message: Antag objective total difficulty is now properly capped.
type: Fix
id: 6913
time: '2024-07-13T04:14:30.0000000+00:00'
url: space-wizards/space-station-14#29830
- author: EmoGarbage404
changes:
- message: Added wristwatches for telling time.
type: Add
id: 6914
time: '2024-07-13T06:09:19.0000000+00:00'
url: space-wizards/space-station-14#29550
- author: TheShuEd
changes:
- message: Added diamonds ore!
type: Add
- message: Diamonds can now be sold at a bargain price.
type: Add
id: 6915
time: '2024-07-13T12:15:57.0000000+00:00'
url: space-wizards/space-station-14#25750
- author: coffeeware
changes:
- message: Lizards will no longer lose their snouts when equipping head bandanas
type: Fix
id: 6916
time: '2024-07-14T02:59:45.0000000+00:00'
url: space-wizards/space-station-14#29979
```
## Admin.yml
```yml
- author: Chief-Engineer
changes:
- message: Baby jail no longer prevents accounts with no prior connections from
connecting
type: Fix
id: 45
time: '2024-07-11T05:14:01.0000000+00:00'
url: space-wizards/space-station-14#29896
```
**Проверки**
<!-- Выполнение всех следующих действий, если это приемлемо для вида
изменений сильно ускорит разбор вашего PR -->
- [x] PR полностью завершён и мне не нужна помощь чтобы его закончить.
- [x] Я внимательно просмотрел все свои изменения и багов в них не
нашёл.
- [x] Я запускал локальный сервер со своими изменениями и всё
протестировал.
- [x] Я добавил скриншот/видео демонстрации PR в игре, **или** этот PR
этого не требует.
**Изменения**
<!--
Здесь вы можете написать список изменений, который будет автоматически
добавлен в игру, когда ваш PR будет принят.
В журнал изменений следует помещать только то, что действительно важно
игрокам.
В списке изменений тип значка не является часть предложения, поэтому
явно указывайте - Добавлен, Удалён, Изменён.
плохо: - add: Новый инструмент для инженеров
хорошо: - add: Добавлен новый инструмент для инженеров
Вы можете указать своё имя после символа 🆑 именно оно будет
отображаться в журнале изменений (иначе будет использоваться ваше имя на
GitHub)
Например: 🆑 Ian
-->
🆑 Шрёдька
- tweak: Подтянуты изменения с корвакса, 21.07.24.
themias
pushed a commit
to themias/space-station-14
that referenced
this pull request
Aug 9, 2024
throwing system hotfix
Baa14453
pushed a commit
to Baa14453/space-station-14
that referenced
this pull request
Oct 19, 2024
throwing system hotfix
SlamBamActionman
added a commit
to SlamBamActionman/space-station-14
that referenced
this pull request
Nov 1, 2024
* VGRoid support (space-wizards#27659) * Dungeon spawn support for grid spawns * Recursive dungeons working * Mask approach working * zack * More work * Fix recursive dungeons * Heap of work * weh * the cud * rar * Job * weh * weh * weh * Master merges * orch * weh * vgroid most of the work * Tweaks * Tweaks * weh * do do do do do do * Basic layout * Ore spawning working * Big breaking changes * Mob gen working * weh * Finalising * emo * More finalising * reverty * Reduce distance * New anomaly behaviour: Invisibility (space-wizards#29120) * invisible anomaly * good luck * Automatic changelog update * feat: allow developers to customize vscode settings, closes space-wizards#29285 (space-wizards#29294) * Allow construction of rotated railings (space-wizards#29687) * Remove southRotation from railing structures * Curly Braces * Automatic changelog update * improved wrench description (space-wizards#29700) Lefty latchy, righty removey * add apc power draw to stat value command (space-wizards#29701) add apc stat value * Dynamic Radial Menus (space-wizards#29678) * fix * Clean Some Code * Some Commentaries * Update Content.Client/UserInterface/Controls/RadialContainer.cs * Update Content.Client/UserInterface/Controls/RadialContainer.cs --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Automatic changelog update * Fixes objects changing physics behavior after being pulled (space-wizards#29694) * Fixes pull rotation logic * cleaner condition * even less code * I CHANGED MY MIND * first one * second one --------- Co-authored-by: plykiya <plykiya@protonmail.com> * Automatic changelog update * Makes portable flashers destructable (space-wizards#29564) Makes portable flashers destructible Co-authored-by: plykiya <plykiya@protonmail.com> * Automatic changelog update * Starting gear for vox crewmembers (space-wizards#29685) * tank harness * weh * Suit Storage Whitelist * Revert "Suit Storage Whitelist" This reverts commit b1f5035. * suit storage filter * vox spawn gear * weh * Make all nukies humans (space-wizards#29693) * Automatic changelog update * Make vox roundstart (space-wizards#29704) * Make vox roundstart I believe all the issues are fixed. * Click detection bandaid * Automatic changelog update * Added Health Analyzer to basic treatment module. (space-wizards#29696) Removed dropped, added Health Analyzer to Basic Treatment Module Co-authored-by: JIP <jipdawg93@gmail.com> * Automatic changelog update * Fix animation looping bugs. (space-wizards#29457) Summary of the problem is in the corresponding engine commit: space-wizards/RobustToolbox@a4ea5a4 This commit requires engine master right now. I think space-wizards#29144 is probably the most severe one, but I touched Jittering and RotatingLight too since they seemed sus too. Fixes space-wizards#29144 Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com> * Automatic changelog update * fix(marathon): Fixing more issues (space-wizards#29411) * fix(packed): Fix a couple of issues (space-wizards#29422) * fix(packed): Fix a couple of issues * Name the signal button for bar * Fix Vox clothing in character creation menu (space-wizards#29709) Update vox.yml * Fix typo in pineapple pizza description (space-wizards#29714) * Move checking code for BlacklistedRange to the right place in sqlite (space-wizards#29389) * Re-enabling nukie species(except vox), added antag species blacklisting * Revert "Make all Nukies humans (space-wizards#29693)" This reverts commit 3e3e050. * Implemented species blacklist * Re-enabled all species as Nukies except for Vox because loadouts don't support breathing alternative gases yet. * Automatic changelog update * Add summary comments for ElectrifiedComponent fields (space-wizards#29733) add summaries for ElectrifiedComponent * Fix showing the inventory button on entities without any inventory slots (space-wizards#29728) * Fire Axe resprite 45 degrees v3 (space-wizards#28866) Rotating Fire Axe 45 deg * nuke biochem (space-wizards#29751) Nuke biomchem again * Shuttle map button tweaks (space-wizards#29757) - Avoids adding pending objects we can never show so the list should fill much faster. * Automatic changelog update * Don't allow toggling internals while asleep (space-wizards#29753) * You no longer get deleted when cuffed and buckled (space-wizards#29718) fix * Fixes a minor typo for the base gingerbread body part (space-wizards#29717) "Fixes a minor typo in the gingerbread bodypart prototype" * Phoronman 1984 (space-wizards#29747) No more. * Added cryosleep UnitSpawner and UnitSpawnerLate to the map Origin (space-wizards#29761) Added cryosleep UnitSpawner and UnitSpawnerLate Co-authored-by: JIP <jipdawg93@gmail.com> * Automatic changelog update * Fix wielding while pulling (space-wizards#29781) * Update Credits (space-wizards#29784) Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com> * Spilling reagents on mutliple entities at once fix (space-wizards#29763) * Fixed! * That could have been bad this is why I'm glad I check the diff xD * Automatic changelog update * Improve buckling's interactions with standing state (space-wizards#29741) * Automatic changelog update * Add supplybot moving states (space-wizards#29795) * Add supplybot moving states * forgor * Raise ratking migration minimum players to 30 from 15 (space-wizards#29737) * Automatic changelog update * Intercom buffs and fixes (space-wizards#29580) * Intercom buffs and fixes * remove unused bui state * mild sec intercom buff * reinforce sec intercoms * Automatic changelog update * Bartending+: Shaking and Stirring (space-wizards#29243) * Shaking and Stirring * Remove shake message * Switch if order a bit * Add doafter supprot for reactionmixer * Fix nullability * Timespan zero * Forgot to remove loc string * Reorganize usings * Remove unneeded usings, fix b52 needing to be shaken * Slicing food with Swords (space-wizards#29005) * added utensil component * BaseSword added * fix(hardsuits): Give the carp suit and hardsuit a suit storage slot (space-wizards#29322) * fix(hardsuits): Give the carp hardsuit suit storage * Both carpsuits have suit slots * Automatic changelog update * metal foam grenades (space-wizards#29428) * metal foam grenades * wow okay * meh * bruh * test * push * The real AME nerf (space-wizards#29587) * The real AME nerf * oh the real change * Update AmeNodeGroup.cs * Removes max damage threshold on healing for hyperzine (space-wizards#29712) * Removes max damage threshold for hyperzine * the description... --------- Co-authored-by: plykiya <plykiya@protonmail.com> * Automatic changelog update * Silence ringtones on admin PDAs (space-wizards#29801) * Silence ringtones on invisible PDAs * Revert "Silence ringtones on invisible PDAs" This reverts commit afc1041. * Literally just this * Add an admin announcement for news article publishing * Automatic changelog update * Fixed the guide book entry for Diona's blood type (space-wizards#29805) Fixed the entry for Diona's blood type Co-authored-by: JIP <jipdawg93@gmail.com> * Improve throwing precision (space-wizards#29726) * improve throwing precision * remove debugging logs * minor fixes * f * Update Content.Shared/Throwing/LandAtCursorComponent.cs --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Automatic changelog update * Don't treat vgroid as station grid (space-wizards#29811) Forgot I added this toggle. * Vox guidebook entry (space-wizards#29713) * vox guidebook entry * skreee * Removed incorrect diet reference * Automatic changelog update * Restore a panic bunker cvar in wizardsDen.toml (space-wizards#29832) Update wizardsDen.toml * all toggle light actions have a 1 second use delay (space-wizards#29833) * Automatic changelog update * Fix Shotgun Spam Loading (space-wizards#29827) * Automatic changelog update * Add popup for healing target (space-wizards#29804) * Add popup for healing target * hop * huh * fix one * fix showing popup to all * Add popup for health analyzer target (space-wizards#29803) * Add popup for health analyzer target * addition * fix showing popup to all * localization and change of appearance of the phrase about the remaining time (space-wizards#29844) * Action menu localization (space-wizards#29839) * fix passive vent sprite in construction menu (space-wizards#29820) * Automatic changelog update * Let Pacifists Use Certain Guns(Foam Weapons) (space-wizards#29835) Let Pacifists Use Certain Guns(foam) * Automatic changelog update * Fix lobby time typo (space-wizards#29841) * Localization of the threat level in an emergency lamp (space-wizards#29847) * Nozzle Direction Localization (space-wizards#29849) * Aghosts can now /ghost (space-wizards#29360) I will not be subjected to criminal abuse * Change Cluster evac (space-wizards#29828) * Update map changes labeler (space-wizards#29858) Update labeler.yml * Stop eating food if you drop it (space-wizards#29854) * Stop eating food if you drop it * woops, unused param * comments --------- Co-authored-by: plykiya <plykiya@protonmail.com> * Automatic changelog update * Fix colornetwork desc and help (space-wizards#29856) * Fix colornetwork description * suggested changes * forgor * done * ok now it IS done * made the guitars be able to be worn on suitstorage (space-wizards#29048) * made the guitars be able to be worn on suitstorage * minor fix * Automatic changelog update * Fix borg's popup spam (space-wizards#29861) Fix borg popup spam Co-authored-by: Winkarst-cpu <Winkarst@users.noreply.github.com> * Automatic changelog update * Steal Objective Condition now support stacks (space-wizards#29843) * Update StealConditionSystem.cs * Update StealConditionSystem.cs * fixed missing characters in OwO accent (space-wizards#29047) replaced two characters with ones that actually show up ingame * Add scarf to warm clothing bounty (space-wizards#29779) * Add scarf to warm clothing bounty * Added ClothingScarfBase prototype and assigned to all of the scarves * Automatic changelog update * Add an option to the admin fax menu to lock papers such that they can't be edited by cybersun pens (space-wizards#28972) * Add option to adminfax for locking papers. * Replace dummy control with margin * Automatic changelog update * books bag tabletop (space-wizards#29863) * books bag tabletop * Update Resources/Prototypes/Entities/Objects/Specific/Librarian/books_bag.yml --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Fix typing indicators! (space-wizards#29492) * First commit * Removed pause stuff * Make the event better * Forgot to add the comment * Proto id stuff * cool comments * serializer * Added the time stuff * Crafting pizza boxes. (space-wizards#29680) * We can now craft pizza boxes * Fixing errors * Automatic changelog update * Custom solution transfer volume popup and item status panel fix (space-wizards#29852) * Fix for custom solution transfer volume * Dirty call to prevent issues * Another fix, git issue --------- Co-authored-by: Winkarst-cpu <Winkarst@users.noreply.github.com> * Automatic changelog update * Fixed jobwhitelist locale (space-wizards#29878) Fixed whitelist locale * Update Core (space-wizards#29880) add * Replace ProtoId<EntityPrototype> uses with EntProtoId (space-wizards#29892) * Character menu asks if you want to save your character on exit (space-wizards#29875) * Character menu asks if you want to save your character on exit * Fix * Another fix, little mistake by me * Update Content.Client/Lobby/UI/CharacterSetupGuiSavePanel.xaml.cs --------- Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com> * Automatic changelog update * Revert Baby Jail (space-wizards#29891) * Revert "SS14-28662 Add Baby Jail: a Jail for Babies (inverse panic bunker) (space-wizards#28763)" This reverts commit 3ceb92a. * Revert configs * Oops * Allow attack while pulling (space-wizards#29703) * Make VirtualItem not block attacking * Remove unneeded usings * Automatic changelog update * Fix baby jail (space-wizards#29896) * Revert "Revert Baby Jail (space-wizards#29891)" This reverts commit 24a2866. * the fix * Fix the ability to shoot out of crates (space-wizards#28961) * Fix the ability to shoot out of crates * Makes it check what inventory the player is in * use IsEntityOrParentInContainer * Fix Issues Github had * gaahhh... Prevents lasers from being shot out of crates * gaahhh... Prevents lasers from being shot out of crates * Fix laser? * hmmm... this is better looking I think? * Uncook indentation * Rerun tests? * Automatic changelog update * Glass Airlocks In Spray Painter (space-wizards#29869) * Automatic changelog update * Picking a ghostrole as an admin will now deadmin you. (space-wizards#29790) * @Forcibly deadmins you * Added checks for AdminDeadminOnJoin * Automatic changelog update * item toggling giga rework + full ninja refactor (space-wizards#28039) * item toggle refactoring and some new systems * add ToggleClothing component/system * unhardcode magboots gravity logic * make magboots and speedboots use ItemToggle and stuff * remove now useless clothing components * update client/server magboots systems * add note to use ItemToggledEvent in ToggleActionEvent doc * refactor PowerCellDraw to use ItemToggle for ui open/close control * add TryUseCharges, refactor charges system * update magboot trigger code * make borg use ItemToggle, network SelectedModule instead of now removed Activated * add AccessToggle for borg * the giga ninja refactor * update ninja yml * update ItemToggle usage for some stuff * fix activatableui requires power * random fixing * yaml fixing * nuke ItemToggleDisarmMalus * make defib use ItemToggle * make things that use power not turn on if missing use charge * pro * fix sound prediction * bruh * proximity detector use ItemToggle * oop * big idiot syndrome * fix ninja spawn rule and make it generic * fix ninja spawn rule yml * move loading profiles into AntagLoadProfileRule * more ninja refactor * ninja yml fixes * the dreaded copy paste ops * remove useless NinjaRuleComponent and ue AntagSelection for greeting * fix invisibility * move IsCompleted to SharedObjectivesSystem * ability fixes * oop fix powercell instantly draining itself * sentient speedboots gaming * make reflect use ItemToggle * fix other test * loadprofilerule moved into its own pr * remove conflict with dragon refactor * remove all GenericAntag code from ninja * ) * probably * remove old enabled * great language bravo vince * GREAT LANGUAGE * who made this language * because it stinks * reparent blood-red magboots to magboots probbbly works * most of the review stuff * hasGrav doesnt mean what i thought it did * make health analyzer use itemtoggle, not fail test * fix mag/speed boots being wacky * UNTROLL * add ItemToggle to the random health analyzers * a * remove unused obsolete borg func * untrolling ** fix test * fix * g * untroll --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Fix AtmosDeviceSystem debug assert Heisenbug (space-wizards#29752) Fix AtmosDeviceSystem debug assertion Heisenbug * Revert "Picking a ghostrole as an admin will now deadmin you. (space-wizards#29790)" (space-wizards#29901) This reverts commit 1a50760. * Аnnouncement sender localization (space-wizards#29907) * Better admin note popups text visibility (space-wizards#29909) * Better admin note popup text visibility * Bring buttons closer to the border * Automatic changelog update * Update cluster evac (space-wizards#29885) * Update cluster evac * forgot tiny fans * the change * Update FloorTileSystem to not use Component.Owner() (space-wizards#29930) * Update FloorTileSystem to use EntityUid * missed a variable --------- Co-authored-by: plykiya <plykiya@protonmail.com> * Made musket wieldable. (space-wizards#29910) * Made musket wieldable. * Updated musket rsi meta.json copyright. * Copyright adjustment again. * Automatic changelog update * Allow notice boards to be built on walls (space-wizards#29851) * Make stun batons be thrown like a throwing weapon (space-wizards#29883) * make stun batons be thrown like a throwing weapon * stun prods too * pies too * Automatic changelog update * Update RCDSystem.cs to not use Component.Owner (space-wizards#29940) Update RCDSystem.cs Co-authored-by: plykiya <plykiya@protonmail.com> * Update MapScreen.xaml.cs to not use Component.Owner (space-wizards#29938) Update MapScreen.xaml.cs Co-authored-by: plykiya <plykiya@protonmail.com> * Update BiomeSystem.cs to not use Component.Owner (space-wizards#29939) Update BiomeSystem.cs Co-authored-by: plykiya <plykiya@protonmail.com> * Fixes dropping item in container (space-wizards#29900) * Items droped in containers will end up in containers * Adds integration test for dropping entity while inside container * comment * comment * trim the diff --------- Co-authored-by: plykiya <plykiya@protonmail.com> * Localization of dungeon direction (space-wizards#29911) * Automatic changelog update * Throwing system hotfix (space-wizards#29935) throwing system hotfix * Automatic changelog update * Fix supplybot movement state (space-wizards#29944) Fix supplybot movement sprite * Implement Health Consideration for NPCs (space-wizards#29922) Implement TargetHealthCon * Fix timer deconstruction (space-wizards#29917) Fix deconstruction for timers * Automatic changelog update * Updates GasTankSystem and InternalsSystem to not use Component.Owner (space-wizards#29934) * blah, setup * Updates GasTankSystem and InternalsSystem to not use Component.Owner * squish the diff * Fixa the rest --------- Co-authored-by: plykiya <plykiya@protonmail.com> * Centered hard hat sprites (space-wizards#29953) * Automatic changelog update * Update UtensilSystem.cs to not use Component.Owner (space-wizards#29971) Update UtensilSystem.cs Co-authored-by: plykiya <plykiya@protonmail.com> * Update TriggerSystem.TimedCollide.cs to not use Component.Owner (space-wizards#29970) Update TriggerSystem.TimedCollide.cs Co-authored-by: plykiya <plykiya@protonmail.com> * Change whitelist to pass when null (space-wizards#29981) * Use reinforced glass damage modifier for secure windoors (space-wizards#29941) * Use Rglass damage modifier for reinforced windoors * i actually can remove this line since inherited * Automatic changelog update * Add doc comments to target action components (space-wizards#29982) * Update ShuttleDockControl.xaml.cs to not use Component.Owner (space-wizards#29966) Update ShuttleDockControl.xaml.cs Co-authored-by: plykiya <plykiya@protonmail.com> * Update ActionAlertTooltip.cs to use TryFromMarkup (space-wizards#29975) * Update SmokingSystem.SmokingPipe.cs to not use Component.Owner (space-wizards#29967) Update SmokingSystem.SmokingPipe.cs Co-authored-by: plykiya <plykiya@protonmail.com> * Fix antag objectives always overshooting MaxDifficulty (and kill tries20) (space-wizards#29830) * The death of try20 * Add integration test for traitor gamerule * Fix max difficulty being overshot * Check at least one objective is assigned * EntProtoId * Automatic changelog update * fire extinguisher using item toggle (space-wizards#29906) * move SprayAttemptEvent to shared * add SolutionTransferredEvent * replace FireExtinguisher with SpraySafety * update fire extinguisher yml * invert visuals * always handle event in solution transfer, it makes popups * instantly fill it * untroll --------- Co-authored-by: deltanedas <@deltanedas:kde.org> * Update SalvageSystem.Magnet to not use Component.Owner (space-wizards#29961) * Update SalvageSystem.Magnet.cs * Update SalvageSystem.Magnet.cs the right way --------- Co-authored-by: plykiya <plykiya@protonmail.com> * Update submodule to 228.0.0 (space-wizards#29947) * Update submodule to 228.0.0 * Fix every single test * Also this one * Dummy vox deserves a proper vox name (space-wizards#29789) SKREEEEEeeeeeeee * Watches (space-wizards#29550) * watches * rename * add it into loot pools * Remove imagesharp and StatusEffectAddedEvent from FlashOverlay (space-wizards#28930) remove imagesharp and StatusEffectAddedEvent from FlashOverlay * Automatic changelog update * make cargo balance ui updating its own component (space-wizards#28295) * add BankClientComponent and event * query BankClient instead of hardcoded CargoOrderConsole for updating * add BankClient to all ordering consoles *
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Small corrections to the new throwing system changes done in #29726
This fixes items that are thrown very fast not being "in air". In particular the pneumatic cannon was affected, as using it with with throwing knifes would no longer embed them in the target.
Thanks to @luizwritescode for figuring out the reason for this.
I also buffed the base throwing speed for hands by 10%. Due to my recent change the effective throwing speed was made slightly lower to not overshoot the target. People mentioned that they were no longer able to reflect thrown items from walls in front of them. This adjustment makes it feel more similar to the behaviour before the change, but keeps the throwing precision.
Why / Balance
fixes and adjustments
Technical details
The code comments in the ThrowingSystem before my recent PR said that below a certain threshold flyTime was set to 0 and items never enter the air. However, this was a lie since an offset was applied to the timespan until landing in ThrownItemSystem. I had removed this offset since it was causing problems with precision. The MinFlyTime is no longer necessary due to the precision changes. This fixes items thrown very fast (even over long distances) with a flying time below 0.15s not entering the "in air" state, which prevented embeddable weapons from working.
Media
throw.test.3.mp4
Breaking changes
Changelog
🆑 coffeeware, slarticodefast