Fix for thrown items dealing damage twice to first target

[Plykiya]

About the PR

All I did was delete a function call

Why / Balance

Fixes #26022

Technical details

#18574 called LandComponent() in DamageOtherOnHitSystem as soon as it hits literally anything and regenerated contacts to stop items phasing through walls. Any subsequent hit on other entities will also trigger LandComponent() but because it's already "Landed" from the first call, it doesn't do anything. LandComponent() only triggers on the first hit, regenerates the contacts, and hits the first target twice. Additionally, it doesn't even "land" the item, that's calculated elsewhere.

#18576 fixed what the previous PR was intending to do but did not remove the behavior where it calls LandComponent() on hit because it is seemingly necessary for reasons related to I don't really know. Items no longer phase through walls as a result of this PR, regardless of LandComponent() being called.

#20700 later on made it so that it calls LandComponent() in ThrownItemSystem when the time is appropriate in the lifecycle of the throw and not on the first hit. So LandComponent() is successfully being called when flyTime for the item is less than the currentTime in the game.

In summary, we have no need for that LandComponent() in DamageOtherOnHitSystem anymore so we can just delete it. The only thing it accomplished was duplicating damage on the first hit of an entity.

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

FOR DEMONSTRATION PURPOSES I'M USING A PIERCING SPEAR
Before:

2024-07-16.20-22-49.mp4

After:

2024-07-16.20-20-55.mp4

Breaking changes

nothing

Changelog

🆑

• fix: You no longer deal double damage to your first target when throwing an item.

[Plykiya]

Yes, I've tested throwing items at walls to make sure they don't do anything weird. Everything behaves normally. Nothing is doing anything weird. I've thrown every single item I can find. You can still throw items into trash cans, things still bounce off walls, throwing things in no grav is still fine, etc etc.

[Plykiya]

My feelings are summarized here:

fuck uncommented code, also that test fail isn't mine

[Brandon-Huu]

https://github.com/space-wizards/space-station-14/pull/30115/files#diff-f11356ab6fc02b074291be6f127ce39af7ebbc673b7cc9cca6f4bcab3cc61b9dL35

if (TerminatingOrDeleted(args.Target))
    return;

[EmoGarbage404]

as a wise man once said in another throwing-related PR: i trust you with my life.