2021.4

[javierggt]

ska3-flight 2021.4

Summary:

The main changes in release 2021.4 are improvements to the AGASC supplement. It includes a new version of the AGASC supplement file, which includes a table of star magnitudes estimated by the ACA. The release includes the following:

• A new version of the AGASC supplement file.
• Functionality to regularly update the AGASC supplement.
• Functionality to provide ACA-estimated magnitudes through the existing agasc module interface.

Interface Impacts:

AGASC access

Code that uses the agasc Python package to access star data will use updated magnitude information from the AGASC supplement by default. This can be controlled by the AGASC_SUPPLEMENT_ENABLED environment variable, by use of the agasc.set_supplement_enabled() method, or by explicit use of the use_supplement argument in the methods. See https://sot.github.io/agasc/api.html for the agasc documentation as needed.

Starcheck

The deprecated make_stars output has been removed from starcheck.

ACA Load review checklist update to version 3.7

In parallel with this ska3-flight / starcheck promotion, we also bring a small ACA load review checklist update for approval.  The checklist item change has been reviewed and approved by SSAWG

Remove ACA-044

(this is a link to the full diffs since last release, I haven't been able to find a git link just to the aca load review checklist, but to see just those changes, select "Files Changed" , select "6 changed files", and then select "starcheck/src/aca_load_review_cl.rst -Jean)

Testing:

• Automated testing. Apparent failures are about warning messages caused by testing with current AGASC supplement file, as opposed to with the file to be promoted.

The following tests were done using the supplement file to be promoted:

• Final test on Linux/HEAD. All tests OK.
• Linux on HEAD. All tests OK.
• Mac OS 10.15. All tests OK.
• Windows 10. Tests OK except for a failure in hopper fixed by Fix get_backstop_cmds to work on Windows hopper#22. This
  package is only used operationally in starcheck which does not run on Windows.

Additional testing:

• The AGASC supplement update scripts have been running on a regular weekly schedule since November 2020 while improvements were still being made. The version of AGASC in this release has been running in the test environment since April 2nd 2021.
• The full starcheck regression test set has been run with the agasc supplement disabled via AGASC_SUPPLEMENT_ENABLED=False, as the loads in the regression test set were not built with the supplement. Use of the agasc supplement for load review in starcheck has been functionally tested via use of the ska3-flight test environment against the APR0521T test products (built by the FOT with access to the supplement).

Test environment available on HEAD and GRETA Linux:

/proj/sot/ska3/test

To install the latest test version:

conda create -n ska3-flight-2021.4rc5 --override-channels -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/flight -c https://icxc.cfa.harvard.edu/aspect/ska3-conda/test ska3-flight==2021.4rc5

Review

All operations critical or impacting PR's are independently and carefully reviewed. For other PR's the level of detail for review is calibrated to operations criticality. Some PR's that are confined to aspect-team-specific processing may have little to no independent review.

Deployment:

• 2021.4 release will be promoted to the flight conda channel, and deployed on HEAD and GRETA ska3/flight after the release and products for the week are approved.
• AGASC supplement file will be copied to /proj/sot/ska/data/agasc on HEAD and GRETA.

Code changes

ska3-flight changes (2021.2 -> 2021.4rc5)

Updated Packages

• aca_view: 0.6.0 -> 0.7.2 (0.6.0 -> 0.7.0 -> 0.7.1 -> 0.7.2)
  • PR 80 (javierggt): Small changes
  • PR 81 (javierggt): Added Plots
  • PR 82 (javierggt): Small fixes to work without QtAds and pyqtgraph 0.11.1
  • PR 83 (javierggt): Small bugfixes
• acisfp_check: 3.5.0 -> 3.5.1 (3.5.0 -> 3.5.1)
  • PR 31 (jzuhone): Move conftest for tests
• agasc: 4.10.2 -> 4.11.1 (4.10.2 -> 4.11.0 -> 4.11.1)
  • PR 72 (taldcroft): Add flake8 check to GitHub workflows
  • PR 56 (taldcroft): Improved access to AGASC supplement
  • PR 58 (taldcroft): Faster get_stars() function
  • PR 55 (taldcroft): Handle bad-stars and obs status together
  • PR 77 (javierggt): Flake8
  • PR 76 (javierggt): Bugfixes
  • PR 78 (javierggt): Improved logging
  • PR 82 (javierggt): Obs status
  • PR 85 (javierggt): Added supplement versions table
  • PR 83 (javierggt): Auto yaml
  • PR 86 (javierggt): Added a mechanism to set mag_aca and mag_aca_err manually in the supplement, and a unique star-observation ID
  • PR 92 (javierggt): Added a mechanism to log command-line arguments to be able to re-run
  • PR 100 (javierggt): Fix "telemetry mismatch" error
  • PR 101 (javierggt): Rename observation_id
  • PR 105 (javierggt): Fixture to monkeypatch builtin open function
  • PR 107 (javierggt): Default dtype
  • PR 103 (javierggt): Minor fixes
  • PR 110 (javierggt): Implemented supplement update/promotion workflow
  • PR 112 (javierggt): Tweaks to workflow and improvements to docs
• bep_pcb_check: 3.3.0 -> 3.3.1 (3.3.0 -> 3.3.1)
  • PR 7 (jzuhone): Move conftest for tests
• chandra_aca: 4.32.0 -> 4.32.1 (4.32.0 -> 4.32.1)
  • PR 115 (javierggt): Update a tolerance in obc cen vs gnd sol test
• dea_check: 3.4.0 -> 3.4.1 (3.4.0 -> 3.4.1)
  • PR 31 (jzuhone): Move conftest so tests can catch it
• dpa_check: 3.3.0 -> 3.3.1 (3.3.0 -> 3.3.1)
  • PR 29 (jzuhone): Move conftest so we can use testr
• fep1_actel_check: 3.3.0 -> 3.3.1 (3.3.0 -> 3.3.1)
  • PR 7 (jzuhone): Move conftest for tests
• fep1_mong_check: 3.3.0 -> 3.3.1 (3.3.0 -> 3.3.1)
  • PR 7 (jzuhone): Move conftest for tests
• kadi: 5.5.1 -> 5.6.0 (5.5.1 -> 5.6.0)
  • PR 200 (taldcroft): Make kadi events complete from start of mission
• maude: 3.6.0 -> 3.7.0 (3.6.0 -> 3.7.0)
  • PR 35 (taldcroft): Improve chunked query to tolerate empty chunks
  • PR 34 (jeanconn): Update index and state code files for P015
• mica: 4.25.0 -> 4.26.0 (4.25.0 -> 4.26.0)
  • PR 258 (jeanconn): Disable use of agasc supplement for stats and a specific vv use case
• parse_cm: 3.6.0 -> 3.7.1 (3.6.0 -> 3.7.0 -> 3.7.1)
  • PR 31 (taldcroft): Update maneuver regex to parse prelim neg obsids
  • PR 34 (taldcroft): Ensure the last line of ObsReq is parsed
• proseco: 4.11.1 -> 4.12.1 (4.11.1 -> 4.12.1)
  • PR 351 (javierggt): Fix problem from table API change in astropy 4.2
• psmc_check: 3.3.0 -> 3.3.1 (3.3.0 -> 3.3.1)
  • PR 26 (jzuhone): Move conftest for tests
• ska.engarchive: 4.52.0 -> 4.53.0 (4.52.0 -> 4.53.0)
  • PR 218 (matthewdahmer): Use Telescope Bus 5 and Bus 6 state to calculate relevant derived thermal parameters
  • PR 219 (taldcroft): Fix a problem adding MSIDs to existing content type
• ska3-core: 2021.2 -> 2021.4rc5
• ska_sync: 4.7.0 -> 4.8.0 (4.7.0 -> 4.8.0)
  • PR 23 (taldcroft): Add --sync-mp option for ACA-related SOT mission planning files
  • PR 24 (taldcroft): Update Ska.tdb to p015 and add cdb directory
• sparkles: 4.7.0 -> 4.9.0 (4.7.0 -> 4.8.0 -> 4.9.0)
  • PR 149 (taldcroft): Update tests for AGASC supplement disable as needed
  • PR 151 (taldcroft): Support slicing of ACAReviewTable
• starcheck: 13.8.0 -> 13.10.0 (13.8.0 -> 13.9.0 -> 13.10.0)
  • PR 361 (jeanconn): Remove all make_stars stuff
  • PR 363 (jeanconn): Remove multiple star filter stuff
  • PR 364 (jeanconn): Remove checks for flickering pixel mon windows
  • PR 365 (jeanconn): Recharacterize too few guide warning as yellow warn
  • PR 366 (jeanconn): Remove 'has magnitude been checked' for stealth mon star
  • PR 367 (jeanconn): Remove old ok-no-starcat stuff
  • PR 362 (jeanconn): Remove special case ER checks
  • PR 368 (jeanconn): Remove an orphaned bit of special_case_er code
  • PR 371 (jeanconn): Update ACA model for chandra_models 3.34.1
• xija: 4.21.1 -> 4.23.0 (4.21.1 -> 4.22.0 -> 4.23.0)
  • PR 106 (taldcroft): Add a Delay model component
  • PR 107 (taldcroft): Allow fewer dP pitches + add sensible keyword arg defaults
  • PR 108 (jzuhone): Fix random crashes using xija_gui_fit on Linux, change limit names for annotation, use CxoTime

ska3-core changes (2021.2 -> 2021.4rc5)

New Packages

• ipympl: 0.7.0 : Allow use of better interactive plots via %matplotlib widgets
• nodejs: 10.13.0
• pyqtgraph: 0.11.0 : Make plots in Qt5

Related Issues

Fixes #617
Fixes #618
Fixes #619
Fixes #620
Fixes #621
Fixes #623
Fixes #624
Fixes #625
Fixes #626
Fixes #627
Fixes #628
Fixes #629
Fixes #630
Fixes #631
Fixes #632
Fixes #633
Fixes #634
Fixes #635
Fixes #640
Fixes #641
Fixes #642
Fixes #643
Fixes #644
Fixes #645
Fixes #646