Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move conftest for tests #31

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Move conftest for tests #31

merged 1 commit into from
Apr 1, 2021

Conversation

jzuhone
Copy link
Member

@jzuhone jzuhone commented Mar 18, 2021

Description

Attempting to run the acisfp_check regression tests from the ska3 flight repository results in an error:

import acisfp_check
acisfp_check.test()
...  many errors like this:

____________________ ERROR at setup of test_DEC0919A_viols _____________________
file /Users/aldcroft/miniconda3/envs/ska3/lib/python3.8/site-packages/acisfp_check/tests/test_acisfp_viols.py, line 7
  def test_DEC0919A_viols(answer_store, test_root):
E       fixture 'answer_store' not found
>       available fixtures: capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
>       use 'pytest --fixtures [testpath]' for help on them.

This PR moves the conftest.py file to the actual package so it gets copied over in the install.

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required)

Fixes issue #30

Copy link
Contributor

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this out on my Mac by doing a --user install in the flight Ska3 environment. I confirmed that the imported package is this version and then verified that acisfp_check.test() runs and passes all tests.

I haven't tried all the others, leaving approval of these to other ACISops folks, but it looks like just moving the file into the package does the trick.

@jzuhone jzuhone merged commit ef430c5 into acisops:master Apr 1, 2021
@javierggt javierggt mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants