Faster get_stars() function #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanconn
reviewed
Jan 28, 2021
agasc/agasc.py
Outdated
| @@ -366,33 +406,32 @@ def get_stars(ids, agasc_file=None, dates=None, fix_color1=True, use_mag_est=Fal | |||
| :param dates: Dates for proper motion (scalar or array) (default=Now) | |||
| :param fix_color1: set COLOR1=COLOR2 * 0.85 for stars with V-I color (default=True) | |||
| :param use_mag_est: Use estimated mag from AGASC supplement where available (default=False) | |||
| :param read_entire_agasc: Number of stars above which to read the entire AGASC (default=5000) | |||
There was a problem hiding this comment.
Love that you set the number of stars as function parameter, though the name sounds more like it should be a flag/boolean.
There was a problem hiding this comment.
I kind of agree with Jean that the name suggests something else to me (it suggests a boolean).
I would call it cache_threshold or something like that.
There was a problem hiding this comment.
Changed to method_threshold.
Note - there is no caching involved, on purpose. I don't want to leave the whole AGASC and index dict in memory by default. Maybe a subsequent PR could allow that if it turns out to be useful. In my work the large get_stars calls are just one-offs.
jeanconn
approved these changes
Jan 28, 2021
Add test and other minor improvements Update docs More sensible API
taldcroft
force-pushed
the
faster-get-stars
branch
from
05d6769
to
9a7d4d6
Compare
|
Note that the flake8 issues are unrelated to this PR. |
This was referenced Mar 2, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For getting stars by AGASC_ID, at some point it is faster to just read the entire AGASC catalog into memory. This PR implements that method using a threshold of 5000 stars. That value was determined based on testing on my laptop.
Testing
Functional testing
For the AGASC supplement with about 81000 stars, the original (
tables.read_where()) method takes about 80 seconds, while the new method takes about 13 seconds.