Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixture to monkeypatch builtin open function #105

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Fixture to monkeypatch builtin open function #105

merged 1 commit into from
Mar 2, 2021

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Mar 2, 2021 •
edited
Loading

Description

This PR fixes a test failure that occurs when monkeypatching the builtin open function (See issue #104).

To fix it, I implemented something almost like what I described in issue #104. The main difference is that I implemented it using a fixture

Testing

  • Passes unit tests on MacOS, linux, Windows (at least one required). Note: test should be using run_testr
  • Functional testing

Fixes #

@javierggt javierggt merged commit a1613c8 into master Mar 2, 2021
@javierggt javierggt deleted the monkeypatch branch March 2, 2021 18:40
This was referenced Mar 2, 2021
Closed
Merged
@javierggt javierggt mentioned this pull request Apr 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javierggt @taldcroft