Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The About page is out of bounds #47

Closed
shpaass opened this issue Feb 20, 2024 · 5 comments · Fixed by #61
Closed

The About page is out of bounds #47

shpaass opened this issue Feb 20, 2024 · 5 comments · Fixed by #61
Labels
bug Something isn't working

Comments

@shpaass
Copy link
Owner

shpaass commented Feb 20, 2024

image

@shpaass shpaass added the bug Something isn't working label Feb 20, 2024
@shihan42
Copy link
Collaborator

Perhaps that's the same problem as with #27
I see if I can look into it.

@shihan42
Copy link
Collaborator

Ok, it seems that the changes in 856c455 introduced this bug. The text wrapper relies on the visible rect, not the out-of-window content rect.

@have-fun-was-taken:
It is your commit. Do you remember why that fix was necessary? Could there be another solution to the original problem?

@shpaass
Copy link
Owner Author

shpaass commented Feb 21, 2024

It was a merge of the PR from @veger.

@shihan42
Copy link
Collaborator

Yeah, my reading comprehension obviously had better days :-)

@veger: Perhaps you can help.

@veger
Copy link
Collaborator

veger commented Feb 21, 2024

I wrote my thoughts in #31 and #34, as well as in the commit. Unfortunately my memory on this is quite spotty as I made these changes over 2 years ago: ShadowTheAge#145

While it was definitely required for something, and I do remember the pain of diving into this GUI code (the style of closely combining the rendering GUIs with performing actions, is very alien to me), I cannot remember for what. Besides it being needed for #38.

It had something to do with the widths/height of panel/areas not being fully calculated but only the visible part. (Obviously) causing issues with scrollareas as those are typically not fully rendered or there wouldn't a need for scrollbars to begin with.

shpaass added a commit that referenced this issue Feb 27, 2024
This partially reverts a457eb2

It looks like a bug (a right coordinate is not 'the size'), but it seems
that AboutScreen is depending on this. Probably because the close icon
is right aligned.

Fixes #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants