Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Popup "Target technology for cost analysis" in Preferences isn't wide enough #27

Closed
shihan42 opened this issue Feb 12, 2024 · 2 comments · Fixed by #62
Closed

[Bug] Popup "Target technology for cost analysis" in Preferences isn't wide enough #27

shihan42 opened this issue Feb 12, 2024 · 2 comments · Fixed by #62
Labels
bug Something isn't working

Comments

@shihan42
Copy link
Collaborator

OS: Win11
YAFC version: b0fa78f

The popup is not wide enough. Increasing width or implementing word wrapping should solve the problem.

grafik
@shihan42 shihan42 added the bug Something isn't working label Feb 12, 2024
@shihan42 shihan42 changed the title [Bug summary] Popup "Target technology for cost analysis" in Preferences isn't wide enough [Bug] Popup "Target technology for cost analysis" in Preferences isn't wide enough Feb 12, 2024
@shihan42
Copy link
Collaborator Author

Ok, this one is harder than expected. Somehow the bounding rectangle ignores the header text. I'm digging through it, but since immediate mode guis are a pita to debug, this will take some time.

@shihan42 shihan42 mentioned this issue Feb 21, 2024
Closed
@veger veger mentioned this issue Feb 27, 2024
Merged
@veger
Copy link
Collaborator

veger commented Feb 27, 2024

It is already broken in the upstream project, in the commit where YAFC CE is forked from: ShadowTheAge@fd80865

And so it has nothing to do with #31 or #34 (saves some work of backtracking the issue)

@veger veger mentioned this issue Feb 27, 2024
Merged
shpaass added a commit that referenced this issue Feb 27, 2024
@shpaass
feature: Fix popup of 'Target technology for cost analysis' preference (
d930ab7 
#62)

The header is too long for the default width of 20f. Make the width
configurable (as it is used in 3 places) and increase the width of this
particular popup.

Also fixed some typos in related code.

Fixes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix popup of 'Target technology for cost analysis' preference veger/yafc-ce
2 participants
@veger @shihan42