Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text alignment of about screen #61

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

veger
Copy link
Collaborator

@veger veger commented Feb 27, 2024

This partially reverts a457eb2

It looks like a bug (a right coordinate is not 'the size'), but it seems that AboutScreen is depending on this. Probably because the close icon is right aligned.

Fixes #47

This partially reverts a457eb2

It looks like a bug (a right coordinate is not 'the size'), but it
seems that AboutScreen is depending on this. Probably because the close
icon is right aligned.
@veger
Copy link
Collaborator Author

veger commented Feb 27, 2024

Note that it has no influence on #27, I'll take a look at this as well (but I wonder if this was already broken in the original YAFC)

Copy link
Owner

@shpaass shpaass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA: tested that the fix works and doesn't regress the basic functionality

@shpaass shpaass merged commit bad704f into shpaass:master Feb 27, 2024
@veger veger deleted the fix-outofbound-texts branch February 27, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The About page is out of bounds
2 participants