Keep original lastRect to fix some drawing glitches (e.g. in ErrorRow) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a lastContentRect which contains the (correct/out-of-window) size, fixes the contentSize calculation in BuildGui(). I did not see any glich(es) anymore, and the ScrollArea size is set correctly now (showing scrollbars if needed)
shpaass
force-pushed
the
fix-scrollbar-behavior
branch
from
c1be00f
to
a457eb2
Compare
|
rebased on top of |
shpaass
approved these changes
Feb 14, 2024
|
No obvious errors on build and smoke testing. |
shpaass
added a commit
that referenced
this pull request
Feb 29, 2024
I tried to reuse the existing UI of YAFC, so I based the whole thing on a `ProjectPageContents` and a `ProjectPageView`, so it would be recognized and fit into the `MainScreen` (tabs) and serialization. The UI of the new 'Summary' tab is ugly, I tried making it nicer, but I found it hard to understand the `ImGui` and its features and how to use them... So I propose this could be further improved om in separate PRs to get the basic functionality/feature into YAFC already and make it available for everyone (I used it a lot and cannot live without this anymore). I also fixed some issues I found while implementing the Summary tab, moved to #31 and #34, except for: * calculating `DatGrid` width when header is not used (I found the header useless here) The original idea is from ShadowTheAge#123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31 was missing an additional fix for the scroll area and their scrollbars.
With this I did not see any glitches anymore, and the ScrollArea size is set correctly now (showing scrollbars if needed).(hard to see/test, as it was visible for the Summary tab which will be my next PR)
Adding a lastContentRect which contains the (correct/out-of-window) size, fixes the contentSize calculation in BuildGui().