some care for pep8 in pyx in modular

[fchapoton]

found using

pycodestyle --select E111,E401,E701,E702,E703,W605,E711,E712,E713,E721,E722 --filename=*.pyx src/sage/modular/

CC: @tscrim @slel @kliem @kwankyu

Component: modular forms

Author: Frédéric Chapoton

Branch/Commit: 2c956e2

Reviewer: David Coudert

Issue created by migration from https://trac.sagemath.org/ticket/33691

[fchapoton]

Commit: b9bd1d8

[fchapoton]

New commits:

b9bd1d8

some care for pep8 in pyx files in modular/

[fchapoton]

Branch: u/chapoton/33691

[fchapoton]

comment:3

green bot, so please review

[dcoudert]

comment:4

Several times in src/sage/modular/modsym/p1list.pyx: u = u+N -> u = u + N

+    if u < 0:
+        u = u+N
+    if v < 0:
+        v = v+N

[dcoudert]

comment:5

Then you can set it to positive review.

[dcoudert]

Reviewer: David Coudert

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c2cd0fa

using += where possible in p1list

[sagetrac-git]

Changed commit from b9bd1d8 to c2cd0fa

[fchapoton]

comment:7

voilà, merci pour la relecture

[fchapoton]

comment:9

bump to 9.7

[vbraun]

comment:11

Merge failure on top of:

b41385cb73 Trac #33690: some details in symbolic

86455641ca Trac #33669: pep cleanup for tableau_tuple

27101087a8 Trac #33668: remove class inheritance of object in various places

85a7d06fd6 Trac #33667: fix and activate pycodestyle E703 in pyx files

33f8a33230 Trac #33617: sage.modules.fg_pid.fgp_module: Rename a test_... function to test... (with deprecation)

59ac550708 Trac #33234: Fix randrange deprecation warning with python-3.10

3b2d987d12 Trac #33124: Add pictures to point.py documentation

47aafd985b Trac #33016: Fix global import of sage.repl.rich_output.display_manager.get_display_manager

36a1715818 Trac #28598: Documentation error for Stein-Watkins database

6f6a100a94 Trac #27522: implement Conway polynomial

de2ccba710 Trac #25626: Add doctest for integrating exp(t)/(t + 1)^2 with giac

362b34f9f6 Trac #33867: tweak our .lgtm file, add documentation

b875e5ceeb Trac #33864: Update cython to 0.29.30

5b4e04a355 Trac #33858: Further parallelization for fundamental group of curves.

32a0bec22b Trac #33847: Bug in h_star_vector for polytopes with the normaliz backend

a6820b32f4 Trac #33838: Refactoring run_autogen [to generate wrappers] to pkgs/sagemath-standard/setup.py

6826987b2f Trac #33831: deprecate unused PermutationGroup_generic.has_element

adaf499a21 Trac #33786: Top-level sage script: Unconditionally set SAGE_ROOT

4056a36c23 Trac #33784: provide a framework for finite group actions

054e8ed8d9 Trac #33316: Drop support for GCC < 6.3 in Sage 9.7

fa3b529 Trac #25833: Upgrade to MathJax 3 and configure Sage

e2ebf44 Trac #33825: Use pytest-xdist to run pytest in parallel

b400962 Trac #33824: make gens and orbits of PermutationGroup immutable

af23627 Trac #33809: some pathlib in combinat and groups

955b5d9 Trac #33803: Fixes for the distributions sagemath-objects, sagemath-categories

3e6b41f Trac #33799: Replace SAGE_TMP in doctests of sage.misc.{persist,ostools}, sage.doctest, sage.repl

a3fd718 Trac #33797: sage.misc.temporary_file: Remove use of SAGE_TMP

2ca0530 Trac #33794: modules/fp_graded/morphism.py test failure

7037fba Trac #33793: sage.misc.cython: Replace use of SPYX_TMP by a new cached function in sage.misc.temporary_file

d115270 Trac #33787: Installation manual: Update section "system-wide install"

0ae5565 Trac #33782: ci-cygwin: Update python version

833f53d Trac #33779: Remove use of SAGE_TMP in sage.interfaces.latte

b376a8d Trac #33771: SSLContext needs an argument

df168c8 Trac #33763: Refactor src/sage/docs

9597eaf Trac #33748: make accessing coefficients of finite-field elements easier

f02236f Trac #33744: Compute bases/circuits in MatroidUnion

8943dc0 Trac #33743: Faster random tree generator

773ec37 Trac #33740: Add conda dev environment

5e65c16 Trac #33734: variety() for polynomial systems over ℚ using msolve

8e7dcca Trac #33733: allow to use flint for Stirling numbers

6f4efb0 Updated SageMath version to 9.7.beta0

merge was not clean: conflicts in src/sage/modular/modsym/p1list.pyx

[sagetrac-git]

Changed commit from c2cd0fa to 5bfe5e1

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4ed5382	some care for pep8 in pyx files in modular/
5bfe5e1	using += where possible in p1list

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2c956e2

Merge branch 'u/chapoton/33691' in 9.7.b1

[sagetrac-git]

Changed commit from 5bfe5e1 to 2c956e2

[fchapoton]

comment:14

back to positive after trivial rebase

[vbraun]

Changed branch from u/chapoton/33691 to 2c956e2