Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cython to 0.29.30 #33864

Closed
tobiasdiez opened this issue May 18, 2022 · 14 comments
Closed

Update cython to 0.29.30 #33864

tobiasdiez opened this issue May 18, 2022 · 14 comments

Comments

@tobiasdiez
Copy link
Contributor

https://cython.readthedocs.io/en/latest/src/changes.html#id27

needed for #26254 and also for Python 3.11 support (#33842)

CC: @jdemeyer @tscrim @mkoeppe @kwankyu @kliem

Component: build

Author: Matthias Koeppe

Branch: 92e9cff

Reviewer: Kwankyu Lee

Issue created by migration from https://trac.sagemath.org/ticket/33864

@tobiasdiez tobiasdiez added this to the sage-9.7 milestone May 18, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented May 18, 2022

comment:1

The procedure to upgrade packages is explained in https://doc.sagemath.org/html/en/developer/packaging.html#upstream-urls:
sage --package update-latest cython --commit

@mkoeppe
Copy link
Contributor

mkoeppe commented May 18, 2022

comment:2

They're up to 0.29.30 now...

@mkoeppe
Copy link
Contributor

mkoeppe commented May 18, 2022

Branch: u/mkoeppe/update_cython_to_0_29_29

@mkoeppe
Copy link
Contributor

mkoeppe commented May 18, 2022

Commit: 92e9cff

@mkoeppe
Copy link
Contributor

mkoeppe commented May 18, 2022

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented May 18, 2022

New commits:

92e9cffbuild/pkgs/cython: Update to 0.29.30

@mkoeppe mkoeppe changed the title Update cython to 0.29.29 Update cython to 0.29.30 May 18, 2022
@mkoeppe

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented May 19, 2022

@kliem
Copy link
Contributor

kliem commented May 19, 2022

comment:8

I can confirm that 0.29.30 is the minimum cython version that will work for python 3.11.

I started some workflows to see whether this causes any problems.

@kwankyu
Copy link
Collaborator

kwankyu commented May 21, 2022

@kwankyu
Copy link
Collaborator

kwankyu commented May 21, 2022

comment:9

No problem with Sage 9.6.

@vbraun
Copy link
Member

vbraun commented May 26, 2022

Changed branch from u/mkoeppe/update_cython_to_0_29_29 to 92e9cff

@mkoeppe
Copy link
Contributor

mkoeppe commented May 27, 2022

Changed commit from 92e9cff to none

@mkoeppe
Copy link
Contributor

mkoeppe commented May 27, 2022

Changed reviewer from Kwankyu Lee, https://github.com/kliem/sage/pull/52/checks to Kwankyu Lee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants