Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error for Stein-Watkins database #28598

Closed
sagetrac-kimball mannequin opened this issue Oct 12, 2019 · 16 comments
Closed

Documentation error for Stein-Watkins database #28598

sagetrac-kimball mannequin opened this issue Oct 12, 2019 · 16 comments

Comments

@sagetrac-kimball
Copy link
Mannequin

sagetrac-kimball mannequin commented Oct 12, 2019

The documentation for one of the Stein-Watkins database functions appears to have a typo. Specifically, the current documentation here:

http://doc.sagemath.org/html/en/reference/databases/sage/databases/stein_watkins.html

says

The command SteinWatkinsPrimeData(n) returns an iterator
over the curves in the nth Stein-Watkins prime table, which
contains prime conductor elliptic curves of conductor between
n 106 and (n+1) 106.

Unless the function or the database has changed recently,
I believe the 106 should be 108. At least on my home
installation of Sage 8.7, when I run SteinWatkinsPrimeData(0),
I get conductors up to 108.

CC: @slel @JohnCremona

Component: documentation

Keywords: Stein-Watkins database

Author: Frédéric Chapoton

Branch/Commit: 0ee4555

Reviewer: John Cremona

Issue created by migration from https://trac.sagemath.org/ticket/28598

@sagetrac-kimball sagetrac-kimball mannequin added this to the sage-9.0 milestone Oct 12, 2019
@embray
Copy link
Contributor

embray commented Jan 6, 2020

comment:1

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented May 1, 2020

comment:2

Moving tickets to milestone sage-9.2 based on a review of last modification date, branch status, and severity.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 May 1, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@slel

This comment has been minimized.

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 2, 2021

comment:5

Moving this ticket to 9.4, as it seems unlikely that it will be merged in 9.3, which is in the release candidate stage

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Apr 2, 2021
@JohnCremona
Copy link
Member

comment:7

In the raw data files, the documentation of files p.n says:

  p.n   -- curves between n*10^8 and (n+1)*10^8 with prime conductor

so it looks as if the suggested correction is good.

By the way, the Stein-Watkins database does not contain all curves in the range, just the ones they found using a search which was not intended to give complete lists. Since then, Bennett, Gherga and Rechnitzer (see https://www.adelagherga.ca/research/BeGhRe3.pdf) have a list of all curves of prime conductor up to 1010. So it would be possible to make an optional package from that data too (or instead). For primes up to 3108 I have computed all the additional data as for my own curve collection, and those are in the LMFDB -- but 1010 is a lot larger than 3108.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 19, 2021

comment:8

Setting a new milestone for this ticket based on a cursory review.

@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 18, 2021

comment:9

Stalled in needs_review or needs_info; likely won't make it into Sage 9.5.

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 11, 2022
@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

Commit: 9d01ad7

@fchapoton
Copy link
Contributor

comment:11

should be very easy to review


New commits:

9d01ad7about Stein-Watlkins database

@fchapoton
Copy link
Contributor

Branch: u/chapoton/28598

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 13, 2022

Changed commit from 9d01ad7 to 0ee4555

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 13, 2022

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0ee4555about Stein-Watkins database

@fchapoton
Copy link
Contributor

comment:13

green bot, so please review

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 16, 2022

Reviewer: John Cremona

@vbraun
Copy link
Member

vbraun commented May 24, 2022

Changed branch from u/chapoton/28598 to 0ee4555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants