Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.misc.temporary_file: Remove use of SAGE_TMP #33797

Closed
mkoeppe opened this issue May 4, 2022 · 7 comments
Closed

sage.misc.temporary_file: Remove use of SAGE_TMP #33797

mkoeppe opened this issue May 4, 2022 · 7 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 4, 2022

(split out from #33213)

Until tmp_filename and tmp_dir are eliminated from the library, we don't want them cluttering up /tmp. In typical usage, this is easy enough to avoid by using one parent temporary directory to contain all the other temporary files and directories, and then removing that one parent as sage exits.

CC: @orlitzky

Component: refactoring

Author: Michael Orlitzky

Branch: bd76501

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33797
@mkoeppe mkoeppe added this to the sage-9.7 milestone May 4, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 4, 2022

Branch: u/mkoeppe/sage_misc_temporary_file__remove_use_of_sage_tmp

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 4, 2022

Commit: bd76501

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 4, 2022

New commits:

4182565Trac #33213: remove SAGE_TMP from tmp_dir() and tmp_filename().
bd76501Trac #33213: clean up after tmp_filename() and tmp_dir() for now.

@vbraun
Copy link
Member

vbraun commented May 22, 2022

Changed branch from u/mkoeppe/sage_misc_temporary_file__remove_use_of_sage_tmp to bd76501

@vbraun vbraun closed this as completed in a3fd718 May 22, 2022
@seblabbe
Copy link
Contributor

seblabbe commented Jun 1, 2022

Changed commit from bd76501 to none

@seblabbe
Copy link
Contributor

seblabbe commented Jun 1, 2022

comment:6

a follow-up is at #33944

This was referenced May 22, 2022
Closed
Closed
Closed
Closed
Closed
@seblabbe seblabbe mentioned this issue Jun 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @seblabbe @mkoeppe