Fix span for ExprPath variants (issue 25969) #25994
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ |
|
📌 Commit 8867179 has been approved by |
|
Thanks! |
|
The fix was actually still off by a token. Good thing that this wasn't merged yet! Does this need another review? |
|
@bors r=huonw |
|
📌 Commit 0000d4c has been approved by |
|
⌛ Testing commit 0000d4c with merge 5643d52... |
Issue: rust-lang#25969 Compare the span on the stable branch (correct) with the span on the nightly branch (incorrect) for the following example: http://is.gd/lTAo9c. This pull request fixes the regression. @Manishearth has been kind enough to pitch some ideas for a regression test, mainly revolving around testing the span in compile-fail test, but this has proven unsuccessful. Other suggestions/ ideas would be much appreciated!
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
@bors: retry On Wed, Jun 3, 2015 at 9:38 PM, bors notifications@github.com wrote:
|
|
⌛ Testing commit 0000d4c with merge caa21ca... |
|
💔 Test failed - auto-win-gnu-64-nopt-t |
|
@bors: retry |
|
⌛ Testing commit 0000d4c with merge fdd6856... |
|
💔 Test failed - auto-win-gnu-64-nopt-t |
Issue: #25969
Compare the span on the stable branch (correct) with the span on the nightly branch (incorrect) for the following example: http://is.gd/lTAo9c. This pull request fixes the regression.
@Manishearth has been kind enough to pitch some ideas for a regression test, mainly revolving around testing the span in compile-fail test, but this has proven unsuccessful. Other suggestions/ ideas would be much appreciated!