Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser provides bad span for syntax::ast::Expr_::ExprPath #25969

Closed
marcusklaas opened this issue Jun 2, 2015 · 3 comments
Closed

Parser provides bad span for syntax::ast::Expr_::ExprPath #25969

marcusklaas opened this issue Jun 2, 2015 · 3 comments

Comments

@marcusklaas
Copy link
Contributor

The span associated to

<T as Header>::header();

in the AST only contains <.
@marcusklaas marcusklaas mentioned this issue Jun 2, 2015
Closed
@nrc
Copy link
Member

nrc commented Jun 2, 2015

cc me

@marcusklaas marcusklaas mentioned this issue Jun 3, 2015
Merged
Manishearth added a commit to Manishearth/rust that referenced this issue Jun 4, 2015
@Manishearth
Rollup merge of rust-lang#25994 - marcusklaas:issue-25969, r=huonw
71d33cd 
Issue: rust-lang#25969

Compare the span on the stable branch (correct) with the span on the nightly branch (incorrect) for the following example: http://is.gd/lTAo9c. This pull request fixes the regression.

@Manishearth has been kind enough to pitch some ideas for a regression test, mainly revolving around testing the span in compile-fail test, but this has proven unsuccessful. Other suggestions/ ideas would be much appreciated!
@steveklabnik
Copy link
Member

@marcusklaas #25994 fixed this, yes?

@marcusklaas
Copy link
Contributor Author

Correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveklabnik @nrc @marcusklaas