Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend rust reference with section about subtyping and type coercions #25900

Merged
merged 2 commits into from
Jun 4, 2015

Conversation

lorenzb
Copy link
Contributor

@lorenzb lorenzb commented May 30, 2015

My main sources of information are RFC401, the rust IRC channel, and a bunch of experiments to figure out what rustc currently supports.
Note that the RFC calls for some coercion behaviour that is not implemented yet (see #18469).
The documentation in this PR mostly covers current behaviour of rust and doesn't document the future behaviour. I haven't written about receiver expression coercion.

I would be happy to rewrite/adapt the PR according to feedback.

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

Thanks @lorenzb ! This looks fine to me, but I'd like @nikomatsakis to check it out too.

@steveklabnik
Copy link
Member

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors rollup r+

Seems good, thanks.

@bors
Copy link
Contributor

bors commented Jun 3, 2015

📌 Commit babb268 has been approved by nikomatsakis

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 4, 2015
…sakis

My main sources of information are [RFC401](https://github.com/rust-lang/rfcs/blob/master/text/0401-coercions.md), the rust IRC channel, and a bunch of experiments to figure out what `rustc` currently supports.
Note that the RFC calls for some coercion behaviour that is not implemented yet (see rust-lang#18469).
The documentation in this PR mostly covers current behaviour of rust and doesn't document the future behaviour. I haven't written about receiver expression coercion.

I would be happy to rewrite/adapt the PR according to feedback.

r? @steveklabnik
@bors
Copy link
Contributor

bors commented Jun 4, 2015

⌛ Testing commit babb268 with merge 515c386...

@bors
Copy link
Contributor

bors commented Jun 4, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Contributor

bors commented Jun 4, 2015

⌛ Testing commit babb268 with merge b535c56...

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 4, 2015
@Manishearth
Copy link
Member

Needs fd3b6ca

@bors
Copy link
Contributor

bors commented Jun 4, 2015

⛄ The build was interrupted to prioritize another pull request.

@bors
Copy link
Contributor

bors commented Jun 4, 2015

⌛ Testing commit babb268 with merge 8b01f01...

@bors
Copy link
Contributor

bors commented Jun 4, 2015

💔 Test failed - auto-win-gnu-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Wed, Jun 3, 2015 at 11:08 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-nopt-t/builds/194


Reply to this email directly or view it on GitHub
#25900 (comment).

bors added a commit that referenced this pull request Jun 4, 2015
@bors bors merged commit babb268 into rust-lang:master Jun 4, 2015
dlrobertson pushed a commit to dlrobertson/rust that referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants