-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend rust reference with section about subtyping and type coercions #25900
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks @lorenzb ! This looks fine to me, but I'd like @nikomatsakis to check it out too. |
@bors rollup r+ Seems good, thanks. |
📌 Commit babb268 has been approved by |
…sakis My main sources of information are [RFC401](https://github.com/rust-lang/rfcs/blob/master/text/0401-coercions.md), the rust IRC channel, and a bunch of experiments to figure out what `rustc` currently supports. Note that the RFC calls for some coercion behaviour that is not implemented yet (see rust-lang#18469). The documentation in this PR mostly covers current behaviour of rust and doesn't document the future behaviour. I haven't written about receiver expression coercion. I would be happy to rewrite/adapt the PR according to feedback. r? @steveklabnik
⌛ Testing commit babb268 with merge 515c386... |
⛄ The build was interrupted to prioritize another pull request. |
⌛ Testing commit babb268 with merge b535c56... |
Needs fd3b6ca |
⛄ The build was interrupted to prioritize another pull request. |
⌛ Testing commit babb268 with merge 8b01f01... |
💔 Test failed - auto-win-gnu-64-nopt-t |
@bors: retry On Wed, Jun 3, 2015 at 11:08 PM, bors notifications@github.com wrote:
|
My main sources of information are RFC401, the rust IRC channel, and a bunch of experiments to figure out what
rustc
currently supports.Note that the RFC calls for some coercion behaviour that is not implemented yet (see #18469).
The documentation in this PR mostly covers current behaviour of rust and doesn't document the future behaviour. I haven't written about receiver expression coercion.
I would be happy to rewrite/adapt the PR according to feedback.
r? @steveklabnik