use precompiled rustc for non-dist builders #122709

onur-ozkan · 2024-03-18T19:05:11Z

Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple.

As we are going to make rust.download-rustc=if-unchanged default option with #119899, we need to make sure if-unchanged logic never breaks and works as expected.

As an addition, this will significantly improve the build times on CI when there's no change on the compiler.

blocker for #119899

try-job: x86_64-gnu-nopt
try-job: aarch64-apple

bors · 2024-03-18T20:23:48Z

☔ The latest upstream changes (presumably #122690) made this pull request unmergeable. Please resolve the merge conflicts.

onur-ozkan · 2024-04-04T15:08:14Z

@bors try

…default, r=<try> prefer precompiled rustc for x86_64-gnu *-to be filled-* blocker for rust-lang#119899 r? ghost

bors · 2024-04-04T15:09:26Z

⌛ Trying commit 7099a13 with merge 9ec5616...

bors · 2024-04-04T16:59:40Z

☀️ Try build successful - checks-actions
Build commit: 9ec5616 (9ec5616fdf20bd5f5381043eccffbe26506a80ff)

onur-ozkan · 2024-04-04T17:51:06Z

@bors try

bors · 2024-04-04T17:56:19Z

⌛ Trying commit 731c8eb with merge 3a8cf09...

…default, r=<try> prefer precompiled rustc for x86_64-gnu *-to be filled-* blocker for rust-lang#119899 r? ghost

onur-ozkan · 2024-09-17T11:25:23Z

@bors try

bors · 2024-09-17T11:26:34Z

⌛ Trying commit 57274bd with merge 398f406...

…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: x86_64-gnu-nopt

rust-log-analyzer · 2024-09-17T11:33:08Z

The job x86_64-gnu-nopt failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

file:.git/config remote.origin.url=https://github.com/rust-lang-ci/rust
file:.git/config remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
file:.git/config gc.auto=0
file:.git/config http.https://github.com/.extraheader=AUTHORIZATION: basic ***
file:.git/config branch.try.remote=origin
file:.git/config branch.try.merge=refs/heads/try
file:.git/config submodule.library/backtrace.url=https://github.com/rust-lang/backtrace-rs.git
file:.git/config submodule.library/stdarch.active=true
file:.git/config submodule.library/stdarch.url=https://github.com/rust-lang/stdarch.git
file:.git/config submodule.src/doc/book.active=true
---
---- [ui] tests/ui/allocator/no_std-alloc-error-handler-custom.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/allocator/no_std-alloc-error-handler-custom.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/allocator/no_std-alloc-error-handler-custom/a" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/allocator/no_std-alloc-error-handler-custom/auxiliary" "-C" "panic=abort"
--- stderr -------------------------------
error[E0464]: multiple candidates for `rmeta` dependency `libc` found
##[error]  --> /checkout/tests/ui/allocator/no_std-alloc-error-handler-custom.rs:15:1
   |

bors · 2024-09-17T11:33:18Z

💔 Test failed - checks-actions

Signed-off-by: onur-ozkan <work@onurozkan.dev>

onur-ozkan · 2024-09-17T17:05:06Z

@bors try

bors · 2024-09-17T17:06:16Z

⌛ Trying commit cdc6642 with merge 522a6e2...

…default, r=<try> use precompiled rustc for non-dist builders Makes non-dist builders to use precompiled CI rustc by default if they are available for the target triple. As we are going to make `rust.download-rustc=if-unchanged` default option with rust-lang#119899, we need to make sure `if-unchanged` logic never breaks and works as expected. As an addition, this will significantly improve the build times on CI when there's no change on the compiler. blocker for rust-lang#119899 try-job: x86_64-gnu-nopt try-job: aarch64-apple

bors · 2024-09-17T18:00:28Z

☀️ Try build successful - checks-actions
Build commit: 522a6e2 (522a6e207e579c9b84b96ae6234cc5026199aac8)

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 18, 2024