show linker output even if the linker succeeds #119286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-query-system
|
|
jyn514
force-pushed
the
linker-output
branch
2 times, most recently
from
060a457
to
a34d7ae
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
linker-output
branch
2 times, most recently
from
64cb47a
to
ab6fb2b
Compare
|
also i know we settled on not showing stdout by default but it's useful for debugging search paths - maybe we should show it after all? it seems silly to have to pass both |
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
linker-output
branch
from
ab6fb2b
to
ba4425d
Compare
Noratrieb
reviewed
Dec 25, 2023
bjorn3
reviewed
Dec 25, 2023
| @@ -714,7 +714,7 @@ fn test_unstable_options_tracking_hash() { | |||
| untracked!(unpretty, Some("expanded".to_string())); | |||
| untracked!(unstable_options, true); | |||
| untracked!(validate_mir, true); | |||
| untracked!(verbose, true); | |||
| untracked!(verbose_internals, true); | |||
There was a problem hiding this comment.
Don't diagnostics influenced by this flag end up in the incr cache? It should actually be tracked I think.
There was a problem hiding this comment.
hmm, do we cache diagnostic output? even on errors? that seems very strange to me.
i don't mind changing it to tracked, i'm just confused why it's necessary.
There was a problem hiding this comment.
On errors we don't finalize the incr comp cache, but non-fatal diagnostics are cached afaik. Otherwise we would have to replay the query in question, which we may not be able to do if the query key is not reconstructible from the dep node fingerprint.
bjorn3
reviewed
Dec 25, 2023
bjorn3
reviewed
Dec 25, 2023
jyn514
force-pushed
the
linker-output
branch
from
ba4425d
to
43edbe0
Compare
|
☔ The latest upstream changes (presumably #119662) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
|
hmm. that test has the following comment: rust/tests/incremental/commandline-args.rs Lines 13 to 20 in e9a009f i suppose those lines are all invalid now, it should be testing that the CGU is not reused? i'm not sure why it's testing --verbose specifically, maybe it's enough to test any untracked CLI arg. i'll change it to --diagnostic-width.
i'm realizing your comments are all about #119129. i feel slightly uncomfortable making unrelated changes in this PR ... how do you feel about splitting them into a separate PR so i can assign michaelwoerister? |
Sure |
I prefer not doing this. It is helpful whenever a linkage issue is opened to not have to ask to rerun with |
|
@bors r+ |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 11, 2024
show linker output even if the linker succeeds - show stderr by default - show stdout if `--verbose` is passed - remove both from RUSTC_LOG - hide the linker cli args unless `--verbose` is passed fixes rust-lang#83436. fixes rust-lang#38206. fixes rust-lang#109979. helps with rust-lang#46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134 this is based on rust-lang#119129 for convenience so i didn't have to duplicate the changes around saving `--verbose` in rust-lang@cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12 r? `@bjorn3`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2024
…kingjubilee Rollup of 11 pull requests Successful merges: - rust-lang#119286 (show linker output even if the linker succeeds) - rust-lang#129103 (Don't warn empty branches unreachable for now) - rust-lang#129696 (update stdarch) - rust-lang#129835 (enable const-float-classify test, and test_next_up/down on 32bit x86) - rust-lang#129992 (Update compiler-builtins to 0.1.125) - rust-lang#130052 (Don't leave debug locations for constants sitting on the builder indefinitely) - rust-lang#130077 (Fix linking error when compiling for 32-bit watchOS) - rust-lang#130114 (Remove needless returns detected by clippy in the compiler) - rust-lang#130156 (Add test for S_OBJNAME & update test for LF_BUILDINFO cl and cmd) - rust-lang#130168 (maint: update docs for change_time ext and doc links) - rust-lang#130239 (miri: fix overflow detection for unsigned pointer offset) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 11, 2024
show linker output even if the linker succeeds - show stderr by default - show stdout if `--verbose` is passed - remove both from RUSTC_LOG - hide the linker cli args unless `--verbose` is passed fixes rust-lang#83436. fixes rust-lang#38206. fixes rust-lang#109979. helps with rust-lang#46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134 this is based on rust-lang#119129 for convenience so i didn't have to duplicate the changes around saving `--verbose` in rust-lang@cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12 r? `@bjorn3`
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
Probably should go from iffy to |
|
so. uh. does anyone know how i can test rustc on a mac lol i do not own any apple laptop |
Does aarch64 or x84_64 apple try jobs work for your purpose? EDIT: no, you'll want to look at linker business. |
|
Dear apple target experts, could you take a look at the linker failures and hopefully help us figure out how we can fix them? This PR is trying to change what linker output is displayed and when. @rustbot ping apple |
rustbot
added
the
O-apple
|
Hey Apple notification group! This issue or PR could use some Apple-specific (In case it's useful, here are some instructions for tackling these sorts of cc @BlackHoleFox @hkratz @inflation @madsmtm @nvzqz @shepmaster @thomcc |
|
All compiler_builtins symbols are marked as hidden. I wonder if the logic that determines the contents of the version script accidentally still mentions these hidden symbols as exported. |
|
oh sorry i didn't realize @jieyouxu was going to ping or i would have said what's going on the compiler_builtins errors are annoying but not actually causing test failures. the actual failure is this: i am not sure how to interpret that; it looks to me like the |
I think the "full" stderr (whatever is given to compiletest) is immediately below, |
|
I ran I suspect what may be confusing you is the use of |
|
@bors delegate+ (for try job perms) |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
ok fuck this i'm not messing with it more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--verboseis passed--verboseis passedfixes #83436. fixes #38206. fixes #109979. helps with #46998. cc https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408986134
this is based on #119129 for convenience so i didn't have to duplicate the changes around saving
--verbosein cb6d033#diff-7a49efa20548d6806dbe1c66dd4dc445fda18fcbbf1709520cadecc4841aae12r? @bjorn3