-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ci_rustc_if_unchanged_logic
test
#131434
Conversation
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@bors r+ p=100 |
☀️ Test successful - checks-actions |
I think the test might still be failing after this landed: #131438 (comment) |
Hmm, I was able to reproduce the previous failures and this change fixed them. Let's wait for #131428 and see what happens. |
Finished benchmarking commit (4203c68): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 775.847s -> 775.672s (-0.02%) |
Kind a typo from #122709, which makes
ci_rustc_if_unchanged_logic
test to fail in any PR that has a change in "library" tree (e.g., #131418 (comment)). This fixes that.r? ghost