Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less noisy change-tracker #130368

Closed
wants to merge 5 commits into from
Closed

less noisy change-tracker #130368

wants to merge 5 commits into from

Conversation

onur-ozkan
Copy link
Member

Reduces noise from change-tracker by disabling change-tracker by default and displaying its help messages only in verbose mode. This means users won't see any change-tracker helper or change messages unless it is explicitly enabled in config.toml or the verbose flag is passed.

Alternative to #130356.

@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2024

r? @albertlarsan68

rustbot has assigned @albertlarsan68.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 14, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 14, 2024

This PR modifies config.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@onur-ozkan onur-ozkan mentioned this pull request Sep 14, 2024
Merged
@bjorn3
Copy link
Member

bjorn3 commented Sep 15, 2024

This should allow removing

rust/compiler/rustc_codegen_cranelift/scripts/setup_rust_fork.sh

Lines 26 to 27 in dde7d66

change-id = 999999
, right? If so would you mind removing it in this PR?

@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2024

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@bors
Copy link
Contributor

bors commented Sep 23, 2024

☔ The latest upstream changes (presumably #130716) made this pull request unmergeable. Please resolve the merge conflicts.

@onur-ozkan
print missing change-tracker option only in verbose mode
62d484b 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
do not set change-tracker option with x setup
4d0b1d0 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
update change-id default in config.example.toml
449c844 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
remove change-id from CI script
6ad1c2b 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
remove change-id from cranelift script
70216e6 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
Copy link
Member Author

Rebased to fix merge conflict.

@bors
Copy link
Contributor

bors commented Oct 8, 2024

☔ The latest upstream changes (presumably #122709) made this pull request unmergeable. Please resolve the merge conflicts.

albertlarsan68
albertlarsan68 reviewed Oct 13, 2024
View reviewed changes
src/bootstrap/src/core/build_steps/setup.rs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change, as I think "human" users should be warned about changes by default

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly useful for experts and we should just include this in the documentation instead of turning it on by default.

@onur-ozkan onur-ozkan closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertlarsan68 albertlarsan68 albertlarsan68 left review comments

Assignees

@albertlarsan68 albertlarsan68

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@onur-ozkan @rustbot @bjorn3 @bors @albertlarsan68