Update dependencies. #1211
Update dependencies. #1211
Conversation
|
@Dylan-DPC Don't merge this, yet. I wanted to get feedback first. Also, I'd like to get some more PRs merged first and avoid conflicts. This is based on #1076, with some different changes. This is actually a little slower to build due to warp/hyper, but for me just by a few seconds. I decided to go with warp for the web server. It has pretty good websocket support, among other things. This allows the websocket to serve from the same port which simplifies a lot of things, and makes it easier to run multiple servers. I've also noticed it seems a little faster, although I haven't measured. |
|
converted to draft xD |
|
@ehuss there's also a new release of elasticlunr-rs with |
|
Thanks @Xanewok. Unfortunately the new version brings in a large number of new dependencies, so there is a pretty significant net increase in build times. 🤷 |
|
Ah, that's unfortunate. Let's see if we can fix it upstream to not unconditionally include Chinese/Japanese support. |
|
Pushed mattico/elasticlunr-rs#28 that could help us cut down the newly introduced dependencies of elasticlunr if we don't enable support for Chinese/Japanese indexing. |
|
A 2.3.8 version of elasticlunr-rs is released which allows to opt out of the extra crates needed to support Chinese/Japanese, so we might cut down the number new of dependencies. |
| @@ -117,7 +98,6 @@ pub fn execute(args: &ArgMatches) -> Result<()> { | |||
| info!("Building book..."); | |||
|
|
|||
| // FIXME: This area is really ugly because we need to re-set livereload :( | |||
There was a problem hiding this comment.
Is this still applicable? Do we need to re-set this again?
There was a problem hiding this comment.
Yes. The book is loaded from scratch (and thus the config is reloaded from scratch), and it needs to inject the URL into the output.
|
Thanks for the help with elasticlunr, that makes a big difference! |
Iron does not appear to be maintained anymore. warp/hyper seems to be reasonably maintained. Unfortunately this takes a few seconds more to compile, but shouldn't be too bad. One benefit is that there is no longer a need for a separate websocket port, which makes it easier to run multiple servers at once.
|
@Dylan-DPC I think this should be ready to go. |
* Removed the itertools dependency * Removed an unused feature flag * Stubbed out a toml_query replacement * Update dependencies. * Bump env_logger. * Use warp instead of iron for http server. Iron does not appear to be maintained anymore. warp/hyper seems to be reasonably maintained. Unfortunately this takes a few seconds more to compile, but shouldn't be too bad. One benefit is that there is no longer a need for a separate websocket port, which makes it easier to run multiple servers at once. * Update pulldown-cmark to 0.7 * Switch from error-chain to anyhow. * Bump MSRV to 1.39. * Update elasticlunr-rs. Co-authored-by: Michael Bryan <michaelfbryan@gmail.com>
Some updates to drop old dependencies. The intent here is to keep things updated and more maintainable.
Closes #1107