Allow to opt-out of Chinese/Japanese support #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not feeling particularly strong about the I'd love to land the first commit, which |
|
Dropped the second commit to only fix the misconfigured features in the manifest. |
|
Thank you! I should have noticed that after merging those. |
|
Thanks for merging and releasing a new version! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it's awesome to have, the relevant support doubles the amount of dependencies from 50 to 93, pulling some data/index crates, which can blow up the compilation time considerably, even if the user doesn't require the relevant language support.
It's great to have them enabled by the default but this commit allows to opt out via
--no-default-features --features stemmer, without forcing the user to enumerate every language already supported by the rust-stemmers crate.