Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps #1220

Closed
wants to merge 3 commits into from
Closed

Bump deps #1220

wants to merge 3 commits into from

Conversation

Xanewok
Copy link
Member

@Xanewok Xanewok commented May 13, 2020

Trivial changes separated from #1211

Opened this PR to already merge things that don't require any review and focus only on the breaking changes there.

@ehuss
Copy link
Contributor

ehuss commented May 13, 2020

Is there any particular reason to merge this early? I think there's maybe one more PR I wanted to review before moving forward with 1211.

@Xanewok
Copy link
Member Author

Xanewok commented May 13, 2020

Technically no - wasn't sure how long you wanted to gather the feedback for the other PR and just wanted to help with landing the other trivial dependency upgrades in the meantime.

Feel free to close this if you'd rather resolve everything at once there!

@ehuss
Copy link
Contributor

ehuss commented May 20, 2020

Closed via #1211.

@ehuss ehuss closed this May 20, 2020
@Xanewok Xanewok deleted the bump-deps branch May 20, 2020 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants