Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the feature output or debug un-used? #1107

Closed
tesuji opened this issue Dec 1, 2019 · 3 comments · Fixed by #1211
Closed

Is the feature output or debug un-used? #1107

tesuji opened this issue Dec 1, 2019 · 3 comments · Fixed by #1211
Assignees
Milestone

Comments

@tesuji
Copy link
Contributor

tesuji commented Dec 1, 2019

output = []

Grepping all feature doesn't show anything about output feature:

% git grep -F -w 'feature' -- '*.rs'
src/cmd/mod.rs:6:#[cfg(feature = "serve")]
src/cmd/mod.rs:9:#[cfg(feature = "watch")]
src/cmd/serve.rs:1:#[cfg(feature = "watch")]
src/cmd/serve.rs:114:    #[cfg(feature = "watch")]
src/config.rs:533:    /// Enable the search feature. Default: `true`.
src/main.rs:40:    #[cfg(feature = "watch")]
src/main.rs:42:    #[cfg(feature = "serve")]
src/main.rs:50:        #[cfg(feature = "watch")]
src/main.rs:52:        #[cfg(feature = "serve")]
src/renderer/html_handlebars/hbs_renderer.rs:104:    #[cfg_attr(feature = "cargo-clippy", allow(clippy::let_and_return))]
src/renderer/html_handlebars/hbs_renderer.rs:368:        #[cfg(feature = "search")]
src/renderer/html_handlebars/hbs_renderer.rs:471:    if cfg!(feature = "search") {
src/renderer/html_handlebars/hbs_renderer.rs:482:             search feature"
src/renderer/html_handlebars/mod.rs:8:#[cfg(feature = "search")]
src/theme/mod.rs:5:#[cfg(feature = "search")]
src/theme/searcher/mod.rs:2://! the "search" cargo feature is disabled.
tests/dummy_book/src/first/nested-test-with-anchors.rs:1:// The next line will cause a `testing` test to fail if the anchor feature is broken in such a way
tests/dummy_book/src/first/nested-test-with-anchors.rs:7:// The next line will cause a `rendered_output` test to fail if the anchor feature is broken in
tests/rendered_output.rs:510:#[cfg(feature = "search")]
@tesuji tesuji changed the title Is the feature output un-used? Is the feature output or debug un-used? Dec 1, 2019
@ehuss
Copy link
Contributor

ehuss commented Dec 1, 2019

Looks they were removed when mdbook switched to the log crate in #164. We can probably remove it from Cargo.toml in 0.4.

@ehuss ehuss added this to the 0.4 milestone Dec 1, 2019
@ehuss ehuss self-assigned this Apr 21, 2020
@sanmai-NL
Copy link

@ehuss The output feature is still referenced in the README.

@ehuss
Copy link
Contributor

ehuss commented Dec 10, 2021

Thanks for the heads up, I just updated the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants