Have the table ID be settable, random, or absent in gt()
#286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Adding the `currency()` helper function for specifying custom currencies (#281) Enable table striping options (#236) Path expand all file inputs (#278) Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237) Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220)
schloerke
reviewed
May 8, 2019
schloerke
reviewed
May 8, 2019
schloerke
approved these changes
May 8, 2019
schloerke
approved these changes
May 8, 2019
rich-iannone
added a commit
that referenced
this pull request
May 8, 2019
* master: Have the table ID be settable, random, or absent in `gt()` (#286)
rich-iannone
added a commit
that referenced
this pull request
May 9, 2019
* master: Have the table ID be settable, random, or absent in `gt()` (#286)
rich-iannone
added a commit
that referenced
this pull request
May 9, 2019
* master: (44 commits) Have the table ID be settable, random, or absent in `gt()` (#286) Adding the `currency()` helper function for specifying custom currencies (#281) Enable table striping options (#236) Path expand all file inputs (#278) Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237) Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220) Try again, this time with `travis encrypt --com` Trying again with github token (#223) ...
rich-iannone
added a commit
that referenced
this pull request
Jul 12, 2019
* master: Add the `cells_stubhead_label()` location helper (#276) Refactoring of the `tab_options()` function (#288) Add the `path` argument to `gtsave()` (#290) Refactoring of heading component (#239) Use `sass` package from CRAN (not GitHub) (#313) Add options related to the table <div> (#285) Have the table ID be settable, random, or absent in `gt()` (#286)
rich-iannone
added a commit
that referenced
this pull request
Jul 15, 2019
* master: Add the `cells_stubhead_label()` location helper (#276) Refactoring of the `tab_options()` function (#288) Add the `path` argument to `gtsave()` (#290) Refactoring of heading component (#239) Use `sass` package from CRAN (not GitHub) (#313) Add options related to the table <div> (#285) Have the table ID be settable, random, or absent in `gt()` (#286)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to more explicitly set the table ID though the
idoption ingt(). By default this is set to use the new helper functionid_random(), which is equivalent to the current behavior of having a 10-letter random string being generated with eachgt()call.We can use a custom string here, or, use
NULLto entirely disable ID generation. Here's a basic usage example where we set a customidvalue:The following screen capture shows that the
idfor the enclosing<div>is now set to"name":Here's another showing that the
idattr can be omitted entirely:Fixes: #141.