-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring of formatter functions #232
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending the argument order of paste_between
is switched. I believe there's only one situation in fmt_number_factory
that needs to switch the argument order. Everything else should be ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Appveyor is failing due to R 3.7 not existing. False positive)
* master: Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220) Try again, this time with `travis encrypt --com` Trying again with github token (#223) Use jcheng5 GitHub PAT instead of rich-iannone (#222)
* master: (37 commits) Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237) Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220) Try again, this time with `travis encrypt --com` Trying again with github token (#223) Use jcheng5 GitHub PAT instead of rich-iannone (#222) Update README (#219) Fix for `fmt_date()` that allows `Date` columns to work (#203) Remove check on macOS ...
* master: Adding the `currency()` helper function for specifying custom currencies (#281) Enable table striping options (#236) Path expand all file inputs (#278) Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237) Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220)
* master: (44 commits) Have the table ID be settable, random, or absent in `gt()` (#286) Adding the `currency()` helper function for specifying custom currencies (#281) Enable table striping options (#236) Path expand all file inputs (#278) Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237) Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220) Try again, this time with `travis encrypt --com` Trying again with github token (#223) ...
The formatting functions (
format_*()
) need to be refactored to reduce code complexity and redundancy, and also to provide a means to better test smaller components.This PR focuses on creating a comprehensive suite of helper functions for the various
format_*()
functions (some of which will also be helpful for other package internals), many more tests, and better structuring of the formatter functions.Fixes #229, and fixes #235.