-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfixes and improvements to summary_rows()
#175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some design considerations:
@jcheng5 please feel free to add anything I missed or refine what's here. |
What if there are no groups but we call |
* master: Modify _travis.yml (#263)
schloerke
approved these changes
Apr 24, 2019
rich-iannone
added a commit
that referenced
this pull request
Apr 26, 2019
rich-iannone
added a commit
that referenced
this pull request
Apr 27, 2019
* master: Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244)
rich-iannone
added a commit
that referenced
this pull request
Apr 27, 2019
* master: (37 commits) Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237) Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220) Try again, this time with `travis encrypt --com` Trying again with github token (#223) Use jcheng5 GitHub PAT instead of rich-iannone (#222) Update README (#219) Fix for `fmt_date()` that allows `Date` columns to work (#203) Remove check on macOS ...
rich-iannone
added a commit
that referenced
this pull request
Apr 27, 2019
* master: Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244)
rich-iannone
added a commit
that referenced
this pull request
Apr 27, 2019
* master: Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244)
rich-iannone
added a commit
that referenced
this pull request
Apr 27, 2019
* master: Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237)
rich-iannone
added a commit
that referenced
this pull request
May 8, 2019
* master: Adding the `currency()` helper function for specifying custom currencies (#281) Enable table striping options (#236) Path expand all file inputs (#278) Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237) Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220)
rich-iannone
added a commit
that referenced
this pull request
May 9, 2019
* master: (44 commits) Have the table ID be settable, random, or absent in `gt()` (#286) Adding the `currency()` helper function for specifying custom currencies (#281) Enable table striping options (#236) Path expand all file inputs (#278) Use webshot to generate images of HTML tables (#257) Rewritten vignette for adding summary rows (#273) Move roxygen documentation to Markdown (#253) Store empty-string value in `sep` vector (#274) Bugfixes and improvements to `summary_rows()` (#175) Modify _travis.yml (#263) Make several refactoring improvements to some `format_*()` functions (#244) Include option to hide all column labels (#237) Refactoring of formatter functions (#232) Improvement to the handling of a `pattern` in most `fmt*()` functions (#95) pkgdown cleanup (#226) Make argument names in `tab_options()` more consistent with terminology (#221) dplyr::data_frame deprecated (#195) Remove a unicode character from roxygen documentation (#220) Try again, this time with `travis encrypt --com` Trying again with github token (#223) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug (#142) where aggregation function would operate on all columns and retain only the results for the requested columns. The prior behavior easily results in failures when an aggregation function operates on any column with incompatible data.
The PR also adds functionality for grand summaries (#38, #68). If
groups == FALSE
we obtain a collection of summary rows that operate on all of the data in the table. We can have both groupwise summaries and grand summaries in the same output table. Grand summaries are distinguishable from groupwise summaries by use of a large double border (and placement at the bottom of the table)Finally, the PR applies several fixes for summary label generation and catches several edge cases. It's both more flexible, less prone to failure, and stops (with nice messages) if some of the stricter rules aren't followed. The documentation has been updated to reflect these changes.
Here's a table using a groupwise summary (across all groups):
Here's a table using a grand summary:
Fixes #38
Fixes #68
Fixes #142