Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the tab_options() function #288

Merged
merged 14 commits into from
Jul 11, 2019
Merged

Conversation

rich-iannone
Copy link
Member

This adds several utility functions that minimize repeated code for each options setting. The result is a single line setter (with internal preprocessing and assertion steps) for each option.

@rich-iannone rich-iannone requested a review from schloerke May 9, 2019 19:17
@rich-iannone rich-iannone merged commit c5b84f8 into master Jul 11, 2019
@rich-iannone rich-iannone deleted the tab-options-refactor branch July 11, 2019 20:00
rich-iannone added a commit that referenced this pull request Jul 12, 2019
* master:
  Add the `cells_stubhead_label()` location helper (#276)
  Refactoring of the `tab_options()` function (#288)
  Add the `path` argument to `gtsave()` (#290)
  Refactoring of heading component (#239)
  Use `sass` package from CRAN (not GitHub) (#313)
  Add options related to the table <div> (#285)
  Have the table ID be settable, random, or absent in `gt()` (#286)
rich-iannone added a commit that referenced this pull request Jul 15, 2019
* master:
  Add the `cells_stubhead_label()` location helper (#276)
  Refactoring of the `tab_options()` function (#288)
  Add the `path` argument to `gtsave()` (#290)
  Refactoring of heading component (#239)
  Use `sass` package from CRAN (not GitHub) (#313)
  Add options related to the table <div> (#285)
  Have the table ID be settable, random, or absent in `gt()` (#286)
rich-iannone added a commit that referenced this pull request Jul 16, 2019
* master:
  Add the `cells_stubhead_label()` location helper (#276)
  Refactoring of the `tab_options()` function (#288)
  Add the `path` argument to `gtsave()` (#290)
  Refactoring of heading component (#239)
  Use `sass` package from CRAN (not GitHub) (#313)
  Add options related to the table <div> (#285)
rich-iannone added a commit that referenced this pull request Jul 16, 2019
* master:
  Add the `cells_stubhead_label()` location helper (#276)
  Refactoring of the `tab_options()` function (#288)
  Add the `path` argument to `gtsave()` (#290)
  Refactoring of heading component (#239)
  Use `sass` package from CRAN (not GitHub) (#313)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants