Make multiple_interfaces works on branch add-rrbot-corrections. #101
Conversation
olivier-stasse
commented
Jun 4, 2021
olivier-stasse
commented
- Correct URDF macro
- Add multiple interface commands in the README.md
- Fix controller name for forward_command_controller_position
olivier-stasse
changed the title
Codecov Report
@@ Coverage Diff @@
## add-rrbot-corrections #101 +/- ##
=======================================================
Coverage ? 0.00%
=======================================================
Files ? 3
Lines ? 283
Branches ? 0
=======================================================
Hits ? 0
Misses ? 283
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
@destogl @bmagyar IMHO the add-rrbot-corrections branch should be merged as soon as possible. I did NOT try the diff example and they are probably a lot of small typos that I missed. But it looks like that the community is willing to help. So if you agree with that I would propose to merge as soon as it is possible this the branch to master and then fix the remaining problem in master. Or make it clear to contributors to work on top of this branch. Any feedback welcome. |
olivier-stasse
changed the title
olivier-stasse
changed the title
|
@olivier-stasse sorry I missed this! |
|
Dear @destogl thanks a lot. You are probably super busy. But the next phase is to merge your PR #76. It cannot be done without the review of somebody else than you with writing permissions on the repository. It would be nice if @Karsten1987 could have the writing rights on this repository. If this is fine with you, if you let me have the writing right I also can help on the ros2_control_demos repo for the merging and the review. This would ease the workload on you and @bmagyar. |
|
FYI @Karsten1987 had merge right here for a week ore more now |
|
@bmagyar Thanks for letting me know. |
* Add correction to rrbot launch using arguments and reuse the main file for starting examples. * Rename config package name * Reorder packages and start docs. Not tested yet. * Update lauch and description files to updated structure * Move all files * Corrected launch of position_only example * Make multiple_interfaces works on branch add-rrbot-corrections. (#101) * Fix wrong macro in rrbot_system_multi_interface.urdf * First correction to README.md (forward_command_controller_position) * Bump ros2 CI actions to 2 for setup-ros Co-authored-by: Olivier Stasse <olivier.stasse@laas.fr> * Update readme and test rrbot examples. * Add also DiffBot working * Update README.md Co-authored-by: Jordan Palacios <j.palacios1986@gmail.com> * Apply suggestions from code review Co-authored-by: mahaarbo <mahaarbo@users.noreply.github.com> Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com> * Add rrbot corrections following review of @jordan-palacios (#104) * Implement classical differential wheel robot. * Add rviz configuration file. Co-authored-by: Olivier Stasse <olivier.stasse@laas.fr> Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> * Update README.md Co-authored-by: mahaarbo <mahaarbo@users.noreply.github.com> Co-authored-by: Olivier Stasse <ostasse@laas.fr> Co-authored-by: Olivier Stasse <olivier.stasse@laas.fr> Co-authored-by: Jordan Palacios <j.palacios1986@gmail.com> Co-authored-by: mahaarbo <mahaarbo@users.noreply.github.com> Co-authored-by: Karsten Knese <Karsten1987@users.noreply.github.com>
