Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file path in rrbot_system_multi_interface.urdf.xacro #96

Closed
wants to merge 1 commit into from
Closed

Fix file path in rrbot_system_multi_interface.urdf.xacro #96

wants to merge 1 commit into from

Conversation

olivier-stasse
Copy link
Collaborator

Fix #95

Karsten1987
Karsten1987 approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@Karsten1987 Karsten1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@bmagyar @destogl could anybody merge? I don't have merge rights here.

@olivier-stasse
Copy link
Collaborator Author

Closed in favor of #101

@destogl
Copy link
Member

destogl commented Jun 7, 2021

Closed in favor of #101

@olivier-stasse did you had opportunity to look at #76?

@olivier-stasse
Copy link
Collaborator Author

@destogl Yes thanks a lot for the work you did in #76.
I worked on top of it, and all my proposed changes are in PR #101
Let me know if they are not atomic enough, I can split them if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Karsten1987 Karsten1987 Karsten1987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple interfaces demo not updated
3 participants
@olivier-stasse @destogl @Karsten1987