Make Devfile the default deployment mechanism #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
force-pushed
the
alpha-testing
branch
2 times, most recently
from
6196ab0
to
b1d920b
Compare
openshift-ci-robot
added
the
do-not-merge/work-in-progress
cdrage
force-pushed
the
alpha-testing
branch
3 times, most recently
from
acb7bb2
to
cfd7eef
Compare
|
/retest |
cdrage
force-pushed
the
alpha-testing
branch
16 times, most recently
from
233ef9b
to
d26bc79
Compare
cdrage
force-pushed
the
alpha-testing
branch
3 times, most recently
from
7a0779a
to
66985c5
Compare
cdrage
force-pushed
the
alpha-testing
branch
3 times, most recently
from
d40bcce
to
24726e0
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
cdrage
force-pushed
the
alpha-testing
branch
from
24726e0
to
3a9dde6
Compare
|
/lgtm |
openshift-ci-robot
added
the
lgtm
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
openshift-ci-robot
removed
the
lgtm
Signed-off-by: John Collier <John.J.Collier@ibm.com>
**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Makes Devfile the default deployment mechanism, removing S2I in favour of Devfile deployment. **Which issue(s) this PR fixes**: Closes redhat-developer#3550 **How to test changes / Special notes to the reviewer**: Run: ```sh odo preference set experimental false odo create --starter nodejs odo push ```
…shift testing suite
cdrage
force-pushed
the
alpha-testing
branch
from
282e86a
to
59cc5d2
Compare
|
Re-adding /lgtm since I had to rebase and disable OperatorHub tests. |
|
/lgtm |
|
@cdrage: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
openshift-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What does does this PR do / why we need it:
Makes Devfile the default deployment mechanism, removing S2I in favour
of Devfile deployment.
Which issue(s) this PR fixes:
Closes #3550 #3842
How to test changes / Special notes to the reviewer:
Run: