odo registry list causes panic if preference has not been setup

[mohammedzee1000]

/kind bug

What versions of software are you using?

Master

Operating System:
Fedora 31

Output of odo version:

❯ make bin && sudo cp -avrf ./odo /usr/bin/odo
go build -ldflags="-w -X github.com/openshift/odo/pkg/version.GITCOMMIT=68bc98ba8" cmd/odo/odo.go
'./odo' -> '/usr/bin/odo'
❯ odo version
odo v1.2.5 (68bc98ba8)

How did you run odo exactly?

❯ rm -rf ~/.odo && odo registry list

Actual behavior

❯ rm -rf ~/.odo && odo registry list
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x188db3d]

goroutine 1 [running]:
github.com/openshift/odo/pkg/odo/cli/registry.(*ListOptions).Run(0x316a9c8, 0x0, 0x0)
	/home/mzee1000/workbench/work/golang/redhat/src/github.com/openshift/odo/pkg/odo/cli/registry/list.go:60 +0x5d
github.com/openshift/odo/pkg/odo/genericclioptions.GenericRun(0x2062c80, 0x316a9c8, 0xc000524280, 0x316a9c8, 0x0, 0x0)
	/home/mzee1000/workbench/work/golang/redhat/src/github.com/openshift/odo/pkg/odo/genericclioptions/runnable.go:31 +0x13c
github.com/openshift/odo/pkg/odo/cli/registry.NewCmdList.func1(0xc000524280, 0x316a9c8, 0x0, 0x0)
	/home/mzee1000/workbench/work/golang/redhat/src/github.com/openshift/odo/pkg/odo/cli/registry/list.go:101 +0x5e
github.com/openshift/odo/vendor/github.com/spf13/cobra.(*Command).execute(0xc000524280, 0x316a9c8, 0x0, 0x0, 0xc000524280, 0x316a9c8)
	/home/mzee1000/workbench/work/golang/redhat/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:830 +0x2aa
github.com/openshift/odo/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc000189180, 0x1e47658, 0xc000043920, 0x2)
	/home/mzee1000/workbench/work/golang/redhat/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:914 +0x2fb
github.com/openshift/odo/vendor/github.com/spf13/cobra.(*Command).Execute(...)
	/home/mzee1000/workbench/work/golang/redhat/src/github.com/openshift/odo/vendor/github.com/spf13/cobra/command.go:864
main.main()
	/home/mzee1000/workbench/work/golang/redhat/src/github.com/openshift/odo/cmd/odo/odo.go:67 +0x330

Expected behavior

The preference should be initialized

Any logs, error output, etc?

see above

[mohammedzee1000]

/priority medium

[johnmcollier]

Seems to be the same panic as in #3747 (comment)

The solution for the alpha branch/release was to do always make sure we properly initialize the registry in the preferences file johnmcollier@274acb7

But, should we even be allowing the odo registry commands to run if experimental mode isn't enabled? (I'd assume anything devfile specific is gated under experimental mode until the 2.0 release)

[mohammedzee1000]

I ran it with experimental mode enabled. Note: once I did odo registry add default blah or tried creating etc, it worked fine.

Also, the issue here is panic. Something we ideally SHOULD NOT have, if we can prevent it, maybe gracefully exit if you are not initializing preference

[johnmcollier]

I'm guessing you're setting experimental mode via the ODO_EXPERIMENTAL variable? (Otherwise, odo preference set experimental true would initialize the preferences file)

Agreed that we shouldn't have the panic, and so backporting johnmcollier@274acb7 should fix things

[johnmcollier]

I can work on this

/assign

[cdrage]

Just an FYI. I do have it in this PR as well: #3705

Unsure if the current test failures I'm facing are because of this issue or not. But going to do a quick /retest and will report back.

[johnmcollier]

Decided to close my PR in favour of #3705, which has the same change in there

[girishramnani]

closeing this issue then as #3705 got merge @johnmcollier