Move the devfile feature set out of the experimental mode #3550

girishramnani · 2020-07-13T12:59:15Z

/kind user-story

User Story

As a user I should be able to use the devfile features without having experimental mode enabled. The decision between devfile and s2i will be made based on which config file is present locally.

Acceptance Criteria

It should use devfile by default
It should allow user to use devfile without experimental mode
resolve broken tests

Links

Feature Request:
Related issue:

/kind user-story

**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Makes Devfile the default deployment mechanism, removing S2I in favour of Devfile deployment. **Which issue(s) this PR fixes**: redhat-developer#3550 **How to test changes / Special notes to the reviewer**: Run: ```sh odo preference set experimental false odo create --starter nodejs odo push ``` And it should deploy devfile.

elsony · 2020-07-14T18:05:01Z

Note:

This item is restricted to the Kube inner loop scenario only.
Local docker support should continue to require experimental set to true
odo deploy function should continue to require experimental set to true

elsony · 2020-07-14T18:06:05Z

/area devfile

**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Makes Devfile the default deployment mechanism, removing S2I in favour of Devfile deployment. **Which issue(s) this PR fixes**: redhat-developer#3550 **How to test changes / Special notes to the reviewer**: Run: ```sh odo preference set experimental false odo create --starter nodejs odo push ``` And it should deploy devfile.

cdrage · 2020-07-23T16:18:36Z

I'm implementing Devfile by default in time for the August 4th Alpha release without the experimental mode enabled. There are commands that are not implemented such as:

storage
link
unlink
update
describe

How do you think we should hide this in the UX / UI when Devfile is by default? What if a user wants to deploy / edit an S2I deployment? Should I just update the help usage to say (FOR S2I ONLY) beside the command or something?

kadel · 2020-07-23T17:16:41Z

storag

odo storage is WIP in #3398

link

component->service was implemented in #3557
component->component link is planned in #3423 (This probably won't be implemented in time for 2.0)

ping @dharmit

unlink

planned for this sprint #3563

update

this command should be deprecated in favor of using odo config
I thought that I opened an issue about this, but I can't find it :-/

describe

Looks like we forgot about this one :-( We need to implement this before 2.0 release

**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Makes Devfile the default deployment mechanism, removing S2I in favour of Devfile deployment. **Which issue(s) this PR fixes**: Closes redhat-developer#3550 **How to test changes / Special notes to the reviewer**: Run: ```sh odo preference set experimental false odo create --starter nodejs odo push ```

dharmit · 2020-07-24T04:51:46Z

component->component link is planned in #3423 (This probably won't be implemented in time for 2.0)
ping @dharmit

Indeed, this is not a priority for 2.0.

unlink

planned for this sprint #3563

Intend to open a PR soon now that #3557 is in.

update

this command should be deprecated in favor of using odo config
I thought that I opened an issue about this, but I can't find it :-/

#2688?

kadel · 2020-07-24T07:16:28Z

update

this command should be deprecated in favor of using odo config
I thought that I opened an issue about this, but I can't find it :-/

#2688?

That is one part of that. But I was convinced that I explicitly wrote a user story about deprecating odo update. But It looks like I did not :-/

Found it #3396

For devfile component, it shows the following message

▶ odo update
Experimental mode is enabled, use at your own risk

 ✗  'odo update' command is not available for Devfile based components

for s2i component, there is a deprecation warning

  WARNING: odo update is not available for Devfile based components and will be removed in the future odo versions.

**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Makes Devfile the default deployment mechanism, removing S2I in favour of Devfile deployment. **Which issue(s) this PR fixes**: Closes redhat-developer#3550 **How to test changes / Special notes to the reviewer**: Run: ```sh odo preference set experimental false odo create --starter nodejs odo push ```

kadel · 2020-07-27T12:08:48Z

opened #3644 to cover odo describe

**What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Makes Devfile the default deployment mechanism, removing S2I in favour of Devfile deployment. **Which issue(s) this PR fixes**: Closes redhat-developer#3550 **How to test changes / Special notes to the reviewer**: Run: ```sh odo preference set experimental false odo create --starter nodejs odo push ```

* Add default registry when preferences initialized Signed-off-by: John Collier <John.J.Collier@ibm.com> * Make Devfile the default deployment mechanism for odo **What type of PR is this?** > Uncomment only one ` /kind` line, and delete the rest. > For example, `> /kind bug` would simply become: `/kind bug` /kind feature **What does does this PR do / why we need it**: Makes Devfile the default deployment mechanism, removing S2I in favour of Devfile deployment. **Which issue(s) this PR fixes**: Closes #3550 **How to test changes / Special notes to the reviewer**: Run: ```sh odo preference set experimental false odo create --starter nodejs odo push ``` * Review round 1 * Pass testing * Pass testing * Remove failing devfile test since this test does not run against openshift testing suite * Temporarily disable OperatorHub tests Co-authored-by: John Collier <John.J.Collier@ibm.com>

openshift-ci-robot added the kind/user-story An issue of user-story kind label Jul 13, 2020

girishramnani added the required-for-v2 label Jul 13, 2020

girishramnani assigned cdrage Jul 13, 2020

girishramnani added the triage/needs-information Indicates an issue needs more information in order to work on it. label Jul 13, 2020

cdrage mentioned this issue Jul 13, 2020

WIP Make Devfile the default deployment mechanism for odo 2.0.0 #3552

Closed

kadel mentioned this issue Jul 14, 2020

Release odo v2.0.0-alpha1 #3558

Closed

2 tasks

elsony mentioned this issue Jul 14, 2020

Move devfile kube support out of experimental #3570

Closed

5 tasks

openshift-ci-robot added the area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. label Jul 14, 2020

cdrage mentioned this issue Jul 23, 2020

Make Devfile the default deployment mechanism for odo #3634

Merged

cdrage mentioned this issue Aug 31, 2020

Make Devfile the default deployment mechanism #3705

Merged

openshift-merge-robot closed this as completed in #3705 Sep 10, 2020

rm3l added the v2 Issue or PR that applies to the v2 of odo label Jun 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move the devfile feature set out of the experimental mode #3550

Move the devfile feature set out of the experimental mode #3550

girishramnani commented Jul 13, 2020 •

edited

Loading

elsony commented Jul 14, 2020

elsony commented Jul 14, 2020

cdrage commented Jul 23, 2020

kadel commented Jul 23, 2020

dharmit commented Jul 24, 2020

kadel commented Jul 24, 2020 •

edited

Loading

kadel commented Jul 27, 2020

Move the devfile feature set out of the experimental mode #3550

Move the devfile feature set out of the experimental mode #3550

Comments

girishramnani commented Jul 13, 2020 • edited Loading

User Story

Acceptance Criteria

Links

elsony commented Jul 14, 2020

elsony commented Jul 14, 2020

cdrage commented Jul 23, 2020

kadel commented Jul 23, 2020

dharmit commented Jul 24, 2020

kadel commented Jul 24, 2020 • edited Loading

kadel commented Jul 27, 2020

girishramnani commented Jul 13, 2020 •

edited

Loading

kadel commented Jul 24, 2020 •

edited

Loading