Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Devfile the default deployment mechanism #3705

Merged
merged 7 commits into from
Sep 10, 2020
Merged

Make Devfile the default deployment mechanism #3705

merged 7 commits into from
Sep 10, 2020

Commits on Sep 10, 2020

  1. Add default registry when preferences initialized 

    Signed-off-by: John Collier <John.J.Collier@ibm.com>
    @johnmcollier @cdrage
    johnmcollier authored and cdrage committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    27bf4e7 View commit details
    Browse the repository at this point in the history

  2. Make Devfile the default deployment mechanism for odo 

    **What type of PR is this?**
> Uncomment only one ` /kind` line, and delete the rest.
> For example, `> /kind bug` would simply become: `/kind bug`

/kind feature

**What does does this PR do / why we need it**:

Makes Devfile the default deployment mechanism, removing S2I in favour
of Devfile deployment.

**Which issue(s) this PR fixes**:

Closes redhat-developer#3550

**How to test changes / Special notes to the reviewer**:

Run:

```sh
odo preference set experimental false
odo create --starter nodejs
odo push
```
    @cdrage
    cdrage committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    a60643a View commit details
    Browse the repository at this point in the history

  3. Review round 1

    @cdrage
    cdrage committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    0c6672a View commit details
    Browse the repository at this point in the history

  4. Pass testing

    @cdrage
    cdrage committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    6ca0ef2 View commit details
    Browse the repository at this point in the history

  5. Pass testing

    @cdrage
    cdrage committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    c95d283 View commit details
    Browse the repository at this point in the history

  6. Remove failing devfile test since this test does not run against open… 

    …shift testing suite
    @cdrage
    cdrage committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    85fc30b View commit details
    Browse the repository at this point in the history

  7. Temporarily disable OperatorHub tests

    @cdrage
    cdrage committed Sep 10, 2020
    Configuration menu
    Copy the full SHA
    59cc5d2 View commit details
    Browse the repository at this point in the history